Replace backtrace crate with stabilized std::backtrace implementation
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not comfortable having the stack trace collection of this crate be dependent on a rust specific environment variable. This is a feature of this crate and should thus be controlled by us / users of this crate directly from code. |
MarijnS95
force-pushed
the
std-backtrace
branch
from
20ff10c to
c1ed54e
Compare
|
@Jasper-Bekkers the comment exactly explains that that is the reason that |
Closed
stefnotch
reviewed
Nov 2, 2023
stefnotch
approved these changes
Nov 2, 2023
…tion Rust 1.65 [stabilized `std::backtrace::Backtrace`], which we can use in place of the `backtrace` crate to reduce our dependency stack. Normally `Backtrace::capture()` would listen to the `RUST_BACKTRACE` and `RUST_LIB_BACKTRACE` environment variables, but this is unsuitable for us as capturing backtraces is configured via boolean debug feature flags in the `AllocatorDebugSettings` struct. Fortunately `Backtrace::force_capture()` exists which circumvents these env var checks and always returns a backtrace, and is hence used in the codebase here. Unfortuantely the type no longer implements `Clone` like `backtrace::Backtrace`, requiring us to wrap it in an `Arc` (because most of our types are thread-safe) to clone the `Backtrace` around various (sub)allocations and statistics reports. [stabilized `std::backtrace::Backtrace`]: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#stabilized-apis
MarijnS95
force-pushed
the
std-backtrace
branch
from
ceffaa6 to
5255af8
Compare
MarijnS95
force-pushed
the
std-backtrace
branch
from
5255af8 to
66a96d9
Compare
Jasper-Bekkers
approved these changes
Nov 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sticking to my promise of updating and submitting this old branch in #183.
Fixes #183 (by no longer using the
backrace/cccrate);Fixes #184 (the old approach from that branch).
Rust 1.65 stabilized
std::backtrace::Backtrace, which we can use in place of thebacktracecrate to reduce our dependency stack.Normally
Backtrace::capture()would listen to theRUST_BACKTRACEandRUST_LIB_BACKTRACEenvironment variables, but this is unsuitable for us as capturing backtraces is configured via boolean debug feature flags in theAllocatorDebugSettingsstruct. FortunatelyBacktrace::force_capture()exists which circumvents these env var checks and always returns a backtrace, and is hence used in the codebase here.Unfortuantely the type no longer implements
Clonelikebacktrace::Backtrace, requiring us to wrap it in anArc(because most of our types are thread-safe) to clone theBacktracearound various (sub)allocations and statistics reports.