Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add band ID to list frequency plans RPC #6709

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

cvetkovski98
Copy link
Member

@cvetkovski98 cvetkovski98 commented Nov 15, 2023

Summary

Closes #6686

Changes

  • Added band_id to the FrequencyPlanDescription message
  • Added optional band_id to the ListFrequencyPlansRequest to enable filtering

Testing

  • Updated existing unit test to ensure the fields are populated accordingly

Notes for Reviewers

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@cvetkovski98 cvetkovski98 linked an issue Nov 15, 2023 that may be closed by this pull request
4 tasks
@cvetkovski98 cvetkovski98 self-assigned this Nov 15, 2023
@cvetkovski98 cvetkovski98 added this to the v3.28.1 milestone Nov 15, 2023
@cvetkovski98 cvetkovski98 force-pushed the feature/add-band-id-to-frequencyplansdescription branch from 82630e5 to babcb17 Compare November 16, 2023 18:11
@cvetkovski98 cvetkovski98 marked this pull request as ready for review November 16, 2023 18:13
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@cvetkovski98 cvetkovski98 merged commit 748b329 into v3.28 Nov 17, 2023
16 checks passed
@cvetkovski98 cvetkovski98 deleted the feature/add-band-id-to-frequencyplansdescription branch November 17, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Band ID to the FrequencyPlansDescription message
3 participants