Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Band ID to the FrequencyPlansDescription message #6686

Closed
2 of 4 tasks
KrishnaIyer opened this issue Nov 3, 2023 · 0 comments · Fixed by #6709
Closed
2 of 4 tasks

Add Band ID to the FrequencyPlansDescription message #6686

KrishnaIyer opened this issue Nov 3, 2023 · 0 comments · Fixed by #6709
Assignees
@cvetkovski98
Labels
blocking Another issue or pull request is waiting for this c/shared This is shared between components
Milestone
v3.28.2

Comments

@KrishnaIyer
Copy link
Member

Summary

Add Band ID to the FrequencyPlansDescription message. This is needed for #6644

Current Situation

The the FrequencyPlansDescription message does not contain the band ID.

Why do we need this? Who uses it, and when?

Clients need this information in order to make decisions based on the Band ID. Ex: if the console wants to restrict users to set frequency plans only from a particular band.

Proposed Implementation

  • Add a BandID to the FrequencyPlansDescription message.
  • Update the ListFrequencyPlans RPC implementation to return the band ID in the response message.
  • Test

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Code of Conduct
@KrishnaIyer KrishnaIyer added c/shared This is shared between components blocking Another issue or pull request is waiting for this labels Nov 3, 2023
@KrishnaIyer KrishnaIyer added this to the v3.28.1 milestone Nov 3, 2023
@github-actions github-actions bot added the needs/triage We still need to triage this label Nov 3, 2023
@KrishnaIyer KrishnaIyer mentioned this issue Nov 3, 2023
Closed
4 tasks
@cvetkovski98 cvetkovski98 linked a pull request Nov 15, 2023 that will close this issue
Add band ID to list frequency plans RPC #6709
Merged
6 tasks
@cvetkovski98 cvetkovski98 mentioned this issue Nov 15, 2023
Merged
6 tasks
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Nov 16, 2023
@KrishnaIyer KrishnaIyer modified the milestones: v3.28.1, v3.28.2 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvetkovski98 cvetkovski98

Labels
blocking Another issue or pull request is waiting for this c/shared This is shared between components
Projects
None yet
Milestone
v3.28.2
Development

Successfully merging a pull request may close this issue.

Add band ID to list frequency plans RPC TheThingsNetwork/lorawan-stack
2 participants
@KrishnaIyer @cvetkovski98