Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set multiple frequency plans only in the same band #6644

Closed
2 of 4 tasks
KrishnaIyer opened this issue Oct 19, 2023 · 2 comments · Fixed by #6747
Closed
2 of 4 tasks

Allow users to set multiple frequency plans only in the same band #6644

KrishnaIyer opened this issue Oct 19, 2023 · 2 comments · Fixed by #6747
Assignees
@ryaplots
Labels
c/console This is related to the Console in progress We're working on it
Milestone
v3.28.2

Comments

@KrishnaIyer
Copy link
Member

Summary

This is an extension of #6615

Current Situation

Users can mix and match frequency plans from different bands.

Why do we need this? Who uses it, and when?

When users set multiple FPs from different bands, the backend will return an error.
Since the console already fetches the Band ID, it would be easier to validate this client side.

Proposed Implementation

  • Check that every new plan added after the first one has the same band ID as the first one.
  • Bonus points if the dropdown is only populated with frequency plans in the same band as the first one.

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Code of Conduct
@KrishnaIyer KrishnaIyer added the c/console This is related to the Console label Oct 19, 2023
@KrishnaIyer KrishnaIyer added this to the v3.28.1 milestone Oct 19, 2023
@github-actions github-actions bot added the needs/triage We still need to triage this label Oct 19, 2023
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Oct 23, 2023
@ryaplots ryaplots added the in progress We're working on it label Oct 23, 2023
@KrishnaIyer KrishnaIyer mentioned this issue Nov 3, 2023
Closed
4 tasks
@KrishnaIyer
Copy link
Member Author

This is blocked on #6686

@KrishnaIyer KrishnaIyer added the blocked This can't continue until another issue or pull request is done label Nov 3, 2023
@cvetkovski98 cvetkovski98 mentioned this issue Nov 15, 2023
Merged
6 tasks
@KrishnaIyer KrishnaIyer modified the milestones: v3.28.1, v3.28.2 Nov 16, 2023
@KrishnaIyer KrishnaIyer removed the blocked This can't continue until another issue or pull request is done label Nov 23, 2023
@KrishnaIyer
Copy link
Member Author

@ryaplots: Please see the backend PR #6709.

@ryaplots ryaplots mentioned this issue Dec 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryaplots ryaplots

Labels
c/console This is related to the Console in progress We're working on it
Projects
None yet
Milestone
v3.28.2
Development

Successfully merging a pull request may close this issue.

Allow to only set frequency plans within the same band TheThingsNetwork/lorawan-stack
2 participants
@KrishnaIyer @ryaplots