Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to only set frequency plans within the same band #6747

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Dec 4, 2023

Summary

Closes #6644

Changes

  • Introduce tags in Select options.
  • Add a filterByTag prop and allow filtering by the tag of the first chosen option.

Testing

  1. Log into the console
  2. Proceed to adding a gateway
  3. Choose one frequency plan
  4. Add another frequency plan
  5. See that the dropdown shows frequency plans only within the same band

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Dec 4, 2023
@ryaplots ryaplots added this to the v3.28.2 milestone Dec 4, 2023
@ryaplots ryaplots self-assigned this Dec 4, 2023
@ryaplots ryaplots requested a review from a team as a code owner December 4, 2023 09:00
@github-actions github-actions bot removed the c/console This is related to the Console label Dec 4, 2023
@ryaplots ryaplots merged commit 47f3303 into v3.28 Dec 7, 2023
13 checks passed
@ryaplots ryaplots deleted the feature/multiple-frequency-plans-same-band-id branch December 7, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set multiple frequency plans only in the same band
2 participants