Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make 'Unhook' the default for altered playback speed (or remember it) #1536

Closed
dardoor opened this issue Jul 19, 2018 · 16 comments · Fixed by #3043
Closed
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@dardoor
Copy link

dardoor commented Jul 19, 2018

I watch most videos on faster than default speed and I have to check 'Unhook' every time, if I don't want a pitch change as well.
Youtube and almost every other video player out there alters the speed without changing the pitch, so it seems like a reasonable thing to do.

I wouldn't even mind if the altered playback speed itself was remembered across videos.

@pmiossec
Copy link

I also watch videos at faster speed and would like to see usability improvements to be done.

I also check 'unhook' every time, so remembering it is a very good idea.

I'm also interested by a setting next to "nightcore" and "default" that remember the last speed used.

Because every time I have to set my custom speed (around x1.5) with the slider and it's not as easy than just clicking on a button with already the good settings. And this operation should be as quick as possible because the video is playing at the same time and you are not focused on it....

@theScrabi theScrabi added the feature request Issue is related to a feature in the app label Jul 22, 2018
@dardoor
Copy link
Author

dardoor commented Jul 23, 2018

Yeah, I wonder how many people even want altered pitch, ever.
Removing that section entirely from the playback speed menu would clean up the UI, which now looks a bit cluttered (now there's also a skip silences feature, which looks cool on paper, but properly produced videos don't have many silences, so I'm not sure it's that useful).
For people who do use that feature, you could have an option in the settings to bring it back to the menu...

I don't want to impose my preferences on everyone else, feel free to chime in. But as I said, pretty much every video player (web or not) leaves the pitch intact when changing speed. The only one I remember that didn't do that by default was MPC-HC...

@theScrabi
Copy link
Member

theScrabi commented Jul 23, 2018

@dardoor I'm with you here when it comes to cluttered UI (I have KDE allergy). I like it simple but functional, and for the actual task apropriate UI.
In my opinion I would remove the Pitch section, Percentage select and the Unhook button. The Silence button it think could remain for now, I guess for some podcast it might be usefull.

Additional I want the percent button to be removed in the main UI, maybe replace it with a button that opens the infon screen of the current video, because that is still missing to me.

@karyogamy what is your opinion about this.

@ag-eitilt
Copy link

I understand why linking the two is an option -- if you've ever tried listening to music (or paid attention to it in the background) the "may cause distortion" is very much true. If you're watching for the speech, though, people quickly become unintelligible with even a little pitch shifting. Luckily, not many viewers are going to be switching between music and spoken videos with particular frequency, so making that toggle "sticky" as suggested would be a perfectly workable fix.

@karyogamy
Copy link
Contributor

I agree with regards to the UI cluttering, though I think this really is just an eventual outcome of giving more controls to the user. However, from a technical side, ExoPlayer's speed changer uses an implementation that works well when changing the tempo or the speed (tempo + pitch), but is horrible when changing only the pitch.

This means, for now, there is no real need to have two separate sliders. We can potentially merge the two into one and have a checkbox to toggle between tempo changing and speed changing (which links the tempo and pitch). Just FYI, VLC app also does something similar, but the unlink toggle is hidden beneath the options and is not so easy to use. This is especially true when its use case is designed to let the user determine if the audio playback is speech or music. So, I recommend renaming the unlink button instead of removing it, and making the tempo (rather than speed) change default or having the toggle persist as @ag-eitilt suggested.

The percentage select is there to replace preset percentages because there are two different sliders. If we get rid of the pitch slider, then we should go back to preset percentages. This should also open up that percentage button for other uses, since the pitch is then always synchronized with the tempo. @theScrabi Instead of using the button opening up the info, maybe we can embed the description view into the player UI itself and have that button change the view between the description and the play queue?

@theScrabi
Copy link
Member

theScrabi commented Jul 31, 2018

@theScrabi Instead of using the button opening up the info, maybe we can embed the description view into the player UI itself and have that button change the view between the description and the play queue?

I would not do this, since we would just end up having the detail view twice.

What i suggest is to have a little player UI that will be shown on the bottom of the app. Maybe somethig like this:
screenshot_20180731-154715

@karyogamy
Copy link
Contributor

Looks good to me. We can look into creating that bottom control after the bugfixing phase. This can probably be implemented as part of the base fragment.

Though, the issue with a dedicated detail view button is that it also creates the same workflow as using the detail option in the contextual menu. And if we were to get rid of the option in the menu, then there won't be any ways to get to the detail page without starting playback on a video. So we might want to think about the design again.

@theScrabi
Copy link
Member

I want to add the refactoring of the context menu be part of the bugfix phase. That thing is already bothering me for a while

@Stallonious
Copy link

Yes please unhook and remember last played speed.
I have to change it every time as I always watch videos fast.
I don't know why anyone would want the audio at a fast pitch. Like, really?

Also, Why can't NewPipe have the option to login to your yourtube account like YouTube Vanced?

@theScrabi
Copy link
Member

theScrabi commented Aug 3, 2018

Also, Why can't NewPipe have the option to login to your yourtube account like YouTube Vanced?

from the faq

NewPipe's goal is to as effectively as possible protect its user's privacy. This means, the app only sends information to external servers which is needed to view search results or watch videos.

Having said this, the developers of NewPipe hope it is understandable that they will not implement any form of authentication which might allow tracking a user.

@beccare
Copy link

beccare commented Sep 23, 2018

+1 for remembering speed/pitch-coupling checkbox state permanently
+1 for keeping current speed/speed setting for the next videos at least until closing the app.

@Tikotik
Copy link

Tikotik commented Oct 10, 2018

+1 Remember last playback speed setting. [on/off] option.
More like this browser extension behaviour: Video speed Controller.

  • [on/off] switch for whether to remember last speed setting in options.
  • global.preferred_speed = user defined value (useful to set ur base speed)
  • if event.touch simple_visual_button then toggle current.speed = (global.preferred_speed, 1x)
  • current.speed = individual speed changes from both slider and/or above button
  • remember both current.speed, global.preferred_speed after app closing. Export settings global.preferred_speed value.

@dardoor
Copy link
Author

dardoor commented Oct 31, 2018

Speaking of cleaning up the UI, I just recently saw that the old speed selector was simpler and easier to use, so might as well just bring that back (maybe as an option). Here's a thread about it: #1381

The current one is really not that good. If I hold the phone horizontally I even have to scroll down to get to the checkbox to leave the pitch unaltered, which should really be the default behavior anyway.

@nikolayhg
Copy link

nikolayhg commented Jul 7, 2019

+1 for remembering last selected unlink/tempo/pitch values

Almost always I have to do it, and when I notice that I forgot to change the speed, I am dissatisfied that I lost precious time!

@Stypox Stypox added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Aug 27, 2019
@tumukei
Copy link

tumukei commented Jan 8, 2020

+2020 for such often used feature. If any other settings would require changing each video, people would be bringing out pitchforks already.

Funny thing is the "Reset" button which is useless as the settings reset each video already.

@gkeegan
Copy link
Contributor

gkeegan commented Jan 8, 2020

Reset button isn't useless. It's used for reverting changes in the video you're watching. Say you want to watch one part at 2x and the rest at normal speed. Way easier to press reset than slide everything back to 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.