Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unhooked playback speed changes the default #2870

Closed
wants to merge 1 commit into from
Closed

Make unhooked playback speed changes the default #2870

wants to merge 1 commit into from

Conversation

BarnabyShearer
Copy link

I agree the are other great opotunities discussed in #1536 but this seems such a quick win.

I agree the are other great opotunities discussed in #1536 but this seems such a quick win.
@Stypox
Copy link
Member

Stypox commented Dec 16, 2019

Thank you for the contribution! Could you please provide an apk for testing? Thanks ;-)

@Stypox Stypox added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Dec 16, 2019
@BarnabyShearer
Copy link
Author

Here is a debug build with my change:
app-debug.apk.zip
I am afraid I also managed to forget to add half the change; and I can't work out how to push to this PR. So I have included a patch.

@BeeeWall
Copy link

I'm pretty sure that to add to the PR you just push the commit to the branch you're trying to merge.

@ShareASmile
Copy link
Collaborator

@BarnabyShearer
Thanks for fantastic feature. Would you provide fresh apk based on 0.18.2 fixes as above given apk is not working.

@Stypox
I would love to get this feature added asap to this beautifully crafted lightweight app.

@Stypox
Copy link
Member

Stypox commented Jan 31, 2020

@gillhash this PR has to be redone, since the original branch was deleted and the provided apk seems to be corrupt, so we can't test. But it wouldn't take that much time to do it.

@Stypox Stypox closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants