Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback Speed UI cleanup #2076

Closed
dardoor opened this issue Jan 30, 2019 · 9 comments
Closed

Playback Speed UI cleanup #2076

dardoor opened this issue Jan 30, 2019 · 9 comments

Comments

@dardoor
Copy link

dardoor commented Jan 30, 2019

The playback speed controls UI is a mess, IMO. There are too many elements, which probably nobody uses, taking up valuable space.

  1. The pitch slider -- Does anyone ever use that?
  2. The step selector -- This probably belongs in the settings, not in the main UI (although if you remove the rest there is space for it). Also, if you just make it, say, 10% I doubt anyone would mind.
  3. The 'Unlink' checkbox -- Does anyone want to listen to pitch altered sound? Just keep the default pitch, like Youtube and every other video player does.
  4. Fast forward during silence -- Sounds nice on paper, but I doubt it gets much use, since most videos don't have unnecessary silence.

The worst part of having all these elements is that when I hold the phone in landscape mode I have to scroll down to reach the "unlink" checkbox. And I have to do this with every video, because the setting is not remembered.
Some of these features, which I'm guessing 95% of people never use (points 1, 3 and 4) could perhaps be enabled in the settings, for those who want them.

BTW, this is how the old speed selector looked like:
latest-newpipe-update-lets-you-control-the-playback-speed-of-youtube-videos-390x390_c
What if (in addition to the current speed menu) this was available with "tap and hold", so that you could select one of the preset speeds very quickly?

@theScrabi
Copy link
Member

I think it was a good idea to clean up the playback speed UI, so full ACK from me :)

However a "tap and hold" in general is not a good UI design, as you are hiding features which are not obvious to find.

I would imagine more of a clean-up for the current speed control window. Maybe where you just have a checkbox for changing the pitch and radiobuttons for the speed.

@woorst
Copy link

woorst commented Jan 30, 2019

Fast forward during silence -- Sounds nice on paper, but I doubt it gets much use, since most videos don't have unnecessary silence.

I just want to say I love this feature and would be greatly disappointed to see it removed.

@theScrabi
Copy link
Member

I just want to say I love this feature and would be greatly disappointed to see it removed.

I see it similar, I would leave it as an additional checkbox.

@connectety
Copy link
Contributor

connectety commented Feb 2, 2019

4. Fast forward during silence -- Sounds nice on paper, but I doubt it gets much use, since most videos don't have unnecessary silence.

I use NewPipe to listen to podcasts and this always is a handy feature, but forwarding is always just a button push away.

@Tikotik
Copy link

Tikotik commented Mar 21, 2019

Related : #1536 #1823 #1924

@AntonLee
Copy link

AntonLee commented Jun 4, 2019

What about instead of "tap and hold" adding extended settings menu button in old menu?
Kinda like this:

  • 0.5x
  • 0.75x
  • 1x
  • 1.25x
  • 1.5x
  • 1.75x
  • 2x
  • More settings

@TobiGr
Copy link
Contributor

TobiGr commented Jun 4, 2019

That's the current state. I think we can close this
Screenshot_20190604-120654

@TobiGr TobiGr closed this as completed Jun 4, 2019
@AntonLee
Copy link

AntonLee commented Jun 4, 2019

BTW, this is how the old speed selector looked like:
latest-newpipe-update-lets-you-control-the-playback-speed-of-youtube-videos-390x390_c

I mean adding option to this menu to open current menu.

@Kreijstal
Copy link

don't you dare to remove fast forward on silence, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants