Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entities leftovers #2101

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Fix entities leftovers #2101

merged 11 commits into from
Feb 22, 2024

Conversation

tornac1234
Copy link
Collaborator

@tornac1234 tornac1234 commented Dec 27, 2023 •
edited
Loading

Fixes and stuff:

  • Fix constructor sinking (when playing with more than one player)
  • Vastly improve simulation ownership
  • Some more Quality of Code things

Entity syncing:

  • Fix crash homes not spawning crashes (finally !)
  • Sync geysers erupting (more immersion = the best)
  • Sync reefback children spawning
  • Sync creature respawn and cooked creature (when dead by fire)

World loading improvements:

  • "Fully" refactored WorldEntityManager
  • Change world loading to only spawn entities in view range
  • Improve entity loading by no longer caching GameObjects when unloading a cell

(done) Needs #2093 to be merged (this branch is built onto it)

@tornac1234 tornac1234 added Area: persistence Related to serialization for long term storage (i.e. files and databases) Area: spawning Related to spawning and/or terrain labels Dec 27, 2023
This was linked to issues Dec 27, 2023
Crash fish don't activate consistently #2045
Closed
Sulfur Creature is stuck inside of the sulfur pod. Cannot progress the game. #1539
Closed
@tornac1234
Copy link
Collaborator Author

tornac1234 commented Jan 6, 2024 •
edited
Loading

There's still a bug with crash homes to be fixed, will be done after #2099 and #2100 are merged (also review corrections aren't committed yet)

@Jannify Jannify linked an issue Jan 8, 2024 that may be closed by this pull request
building never goes to 100% on the server side #2104
Closed
This was unlinked from issues Jan 8, 2024
Sulfur Creature is stuck inside of the sulfur pod. Cannot progress the game. #1539
Closed
Crash fish don't activate consistently #2045
Closed
building never goes to 100% on the server side #2104
Closed
This was linked to issues Jan 9, 2024
Crash fish don't activate consistently #2045
Closed
Sulfur Creature is stuck inside of the sulfur pod. Cannot progress the game. #1539
Closed
@tornac1234 tornac1234 force-pushed the entity-leftovers branch 2 times, most recently from 10d1535 to b764d10 Compare January 11, 2024 20:54
@tornac1234 tornac1234 force-pushed the entity-leftovers branch 2 times, most recently from c3544df to 8a7509f Compare January 21, 2024 01:23
@tornac1234
Copy link
Collaborator Author

To be tested

@BrightenedDay BrightenedDay mentioned this pull request Jan 30, 2024
Closed
Jannify
Jannify requested changes Feb 7, 2024
View reviewed changes
NitroxPatcher/Patches/Dynamic/CrashHome_Spawn_Patch.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/Entities.cs Show resolved Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Bases/BuildEntity.cs Outdated Show resolved Hide resolved
NitroxServer/GameLogic/Entities/EntitySimulation.cs Show resolved Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/GeyserEntitySpawner.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/CreatureDeath_OnKillAsync_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/CreatureDeath_OnKillAsync_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/CreatureDeath_OnKillAsync_Patch.cs Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/CreatureDeath_SpawnRespawner_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/Eatable_IterateDespawn_Patch.cs Show resolved Hide resolved
@tornac1234 tornac1234 mentioned this pull request Feb 15, 2024
Open
10 tasks
@tornac1234 tornac1234 requested a review from Measurity February 16, 2024 13:11
Jannify
Jannify reviewed Feb 22, 2024
View reviewed changes
NitroxModel/DataStructures/GameLogic/Entities/PlanterEntity.cs Outdated
@@ -22,9 +22,9 @@ public PlanterEntity(NitroxId id, NitroxId parentId)
ParentId = parentId;
}

/// <remarks>Used for deserialization</remarks>
/// <remarks>Used for deserialization. Should not be used for something else</remarks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old comment

@tornac1234 tornac1234 merged commit ffe3352 into SubnauticaNitrox:master Feb 22, 2024
@Measurity Measurity added this to the 1.8 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakonkinst Drakonkinst Drakonkinst left review comments

@Jannify Jannify Jannify approved these changes

@Measurity Measurity Measurity approved these changes

Assignees
No one assigned
Labels
Area: persistence Related to serialization for long term storage (i.e. files and databases) Area: spawning Related to spawning and/or terrain
Projects
None yet
Milestone
1.8
4 participants
@tornac1234 @Measurity @Drakonkinst @Jannify