-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync radiation leaks #2100
Merged
Merged
Sync radiation leaks #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Dec 23, 2023
- Sync radiation leak fixing (can be fixed by two people at a time)
- Recalculates the radiation radius based on the time at which the last unfixed leak was fixed
- Add a subsystem to modify worlds when they're created, in this case it's used to create the radiation leak entities but it could be used as well for BZ
- Desync-proof local radiation updates because I replaced Time.deltaTime by our own loss-less deltaTime.
- Add a "real elapsed time" on server-side which is propagated to the client so both of them can work with "Time.deltaTime" behaviours on clients.
tornac1234
added
Area: persistence
Related to serialization for long term storage (i.e. files and databases)
Area: spawning
Related to spawning and/or terrain
labels
Dec 23, 2023
Measurity
requested changes
Dec 26, 2023
NitroxClient/GameLogic/Spawning/Metadata/Extractor/RadiationMetadataExtractor.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/RadiationMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
Jannify
requested changes
Jan 2, 2024
NitroxClient/GameLogic/Spawning/Metadata/Extractor/Abstract/EntityMetadataExtractor.cs
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/RadiationLeakEntitySpawner.cs
Show resolved
Hide resolved
… (for first player joining during queue)
…T> for DI in metadata extractors and processors
tornac1234
force-pushed
the
sync-radiation
branch
from
January 5, 2024 19:48
1746998
to
b794c7f
Compare
Jannify
approved these changes
Jan 5, 2024
Measurity
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: persistence
Related to serialization for long term storage (i.e. files and databases)
Area: spawning
Related to spawning and/or terrain
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.