Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync leviathans gameplay #2106

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sync leviathans gameplay #2106

wants to merge 7 commits into from
+2,959 −322

Conversation

tornac1234
Copy link
Collaborator

@tornac1234 tornac1234 commented Jan 10, 2024 •
edited
Loading

Creature sync:

  • Sync Reaper Leviathans
  • Sync Sea Dragons
  • Sync Sea Treaders

Creature behaviours:

  • Sync leviathans attacking cyclops
  • Sync leviathans attacking a player or vehicle (seamoth or exosuit)

Weapon sync:

  • Sync statis rifle
  • Sync torpedos (better than current implementation)

Other related issues:

  • Fix player vitals not showing a creative player's name
  • Fix seamoth not spawning module inventory
  • Adds an InfectedMixin and a LiveMixin on remote players to ensure they're potential targets

TODO when everything is done:
- [ ] Ensure crash fishes can target other players POSTPONED to another PR (will be short but required both this one and #2101 )

@tornac1234
Copy link
Collaborator Author

Would require some tests :)

@tornac1234 tornac1234 mentioned this pull request Jan 10, 2024
Open
2 tasks
@tornac1234 tornac1234 added Area: player Related to player character actions Area: AI Related to state machines (as used by the fish) labels Jan 10, 2024
@tornac1234 tornac1234 changed the title Sync leviathans Sync leviathans gameplay Jan 18, 2024
@tornac1234
Copy link
Collaborator Author

tornac1234 commented Jan 18, 2024 •
edited
Loading

There's still the following to be looked into (but most of the code is ready for review):

  • sometimes, move animation are chunky and you can see a small jump (FIXED)
  • when another player gets eaten by a leviathan, they broadcast the related cinematic which is played on other players so a black screen appears as if they got eaten themselves by a leviathan (but they didn't)

Jannify
Jannify requested changes Feb 7, 2024
View reviewed changes
NitroxPatcher/Patches/Dynamic/Creature_ChooseBestAction_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/AttackCyclops_UpdateAggression_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/AttackCyclops_UpdateAggression_Patch.cs
float aggressiveToNoise = __instance.aggressiveToNoise.Value;

Resolve<IPacketSender>().Send(new AttackCyclopsTargetChanged(creatureId, targetId, aggressiveToNoise));
ErrorMessage.AddMessage($"[SEND] {__instance.gameObject.name} attacks {__instance.currentTarget.name}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning debug message so it's not forgotten.

NitroxClient/GameLogic/AI.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/BulletManager.cs Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/AttackCyclops_OnCollisionEnter_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/SeamothTorpedoWhirlpool_Register_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/StasisSphere_OnHit_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/StasisSphere_Shoot_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/Vehicle_TorpedoShot_Patch.cs Outdated Show resolved Hide resolved
@tornac1234
Copy link
Collaborator Author

The latest Sea Dragons sync code wasn't tested because it's really hard without #2113

@tornac1234 tornac1234 force-pushed the sync-leviathans branch 2 times, most recently from 862ae97 to bad5975 Compare February 22, 2024 23:08
@Measurity Measurity added this to the 1.8 milestone Aug 9, 2024
Jannify
Jannify requested changes Oct 24, 2024
View reviewed changes
NitroxClient/Communication/Packets/Processors/SeaDragonAttackTargetProcessor.cs
Comment on lines +48 to +49
// TODO: Adapt this code when #1780 is merged
Utils.PlayEnvSound(seaDragonMeleeAttack.attackSound, collider.transform.position, 20f);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1780 is now merged :D

NitroxClient/GameLogic/AI.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/BulletManager.cs Show resolved Hide resolved
NitroxClient/GameLogic/BulletManager.cs Show resolved Hide resolved
NitroxServer/Communication/Packets/Processors/AggressiveWhenSeeTargetChangedProcessor.cs Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/RangedAttackLastTarget_StartCharging_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/SeaDragon_GrabExosuit_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/SeaDragonAggressiveTowardsSharks_GetAggressionTarget_Patch.cs Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/SeaDragonMeleeAttack_OnTouchFront_Patch.cs Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/SeaDragonMeleeAttack_SwatAttack_Patch.cs Show resolved Hide resolved
This was referenced Oct 29, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartasen dartasen dartasen left review comments

@Jannify Jannify Jannify requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Area: AI Related to state machines (as used by the fish) Area: player Related to player character actions
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@tornac1234 @dartasen @Jannify @Measurity