add job to load messages in from a csv and fix some crucial bugs in twilio.js #1346
Conversation
schuyler1d
added
the
S-work in progress (WIP)
| const countResult = await r.getCount( | ||
| r.knex("message").where("service_id", messageInstance.service_id) | ||
| ); | ||
| const [countResult] = await r |
There was a problem hiding this comment.
A theory about the failure was that this was getting a count rather than a single message -- it therefore deadlocked on two of the same messages coming in, because it didn't need to find just one, but get a full count.
There was a problem hiding this comment.
This makes sense, though it would be good to rename this variable, since it is no longer the count (unless I'm misunderstanding the change).
| @@ -56,13 +56,16 @@ async function convertMessagePartsToMessage(messageParts) { | |||
| const lastMessage = await getLastMessage({ | |||
| contactNumber | |||
| }); | |||
| if (!lastMessage) { | |||
There was a problem hiding this comment.
Often SMS spam comes in. If we failed to find a lastMessage, then this failed rather than returning and completing normally -- leaving a db connection open -- and possibly a transaction.
| const countResult = await r.getCount( | ||
| r.knex("message").where("service_id", messageInstance.service_id) | ||
| ); | ||
| const [countResult] = await r |
There was a problem hiding this comment.
This makes sense, though it would be good to rename this variable, since it is no longer the count (unless I'm misunderstanding the change).
schuyler1d
changed the title
schuyler1d
added
S-ready for stage-main (qa)
|
This was tested on MoveOn's production instance and solved a data-race issue for DB changes described in https://github.com/MoveOnOrg/Spoke/pull/1311#issuecomment-568786302 |
schuyler1d
added
the
S-qa staging round
Fixes # (issue)
Description
This adds a method to run
yarn process-message-csv SOMEMESSAGEFILE.csvon a file and load them message responses into the database all at once -- this is a useful tool when processing messages from outside the twilio api and/or for testing.In writing this, some critical bugs were found in the current twilio processing that may be causing deadlocks on indexes and other problems. This fixes those minimally, awaiting more fixes in e.g.
Checklist: