Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage main #1340

Closed
wants to merge 63 commits into from
Closed

Stage main #1340

wants to merge 63 commits into from

Conversation

ibrand
Copy link
Collaborator

@ibrand ibrand commented Dec 27, 2019

Would love a 👍 from both @lperson and @schuyler1d because I had a merge conflict specifically on the function params in await sendMessage and on a refactor of the var serviceName that I think I resolved correctly, but would love you both to inspect.

@lperson
#1178
#1293
#1179
#1344

@SAnschutz
#1277

@jeffm2001
#1306

@schuyler1d
#1311
#1309
#1346
#1351

lperson and others added 30 commits July 27, 2019 19:36
…a comment about displayAllSteps; got rid of componentDidUpdate because its conditional would never be true
@ibrand ibrand temporarily deployed to spoke-review-stage-main-ejrjzy December 27, 2019 14:57 Inactive
@ibrand ibrand temporarily deployed to spoke-review-stage-main-ejrjzy January 2, 2020 18:32 Inactive
@ibrand ibrand temporarily deployed to spoke-review-stage-main-ejrjzy January 6, 2020 22:15 Inactive
schuyler1d and others added 4 commits January 6, 2020 17:29
… vars

This is because AWS Lambda has a max 4K content for environment variables and env vars like GOOGLE_SECRET are >4K by themselves
@ibrand ibrand temporarily deployed to spoke-review-stage-main-ejrjzy January 7, 2020 22:13 Inactive
@ibrand ibrand temporarily deployed to spoke-review-stage-main-ejrjzy January 12, 2020 04:55 Inactive
This was referenced Jan 13, 2020
@schuyler1d
Copy link
Collaborator

closing this PR which was superceded by https://github.com/MoveOnOrg/Spoke/pull/1367

@schuyler1d schuyler1d closed this Jan 15, 2020
@ibrand ibrand deleted the stage-main branch January 30, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants