-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage main2 #1367
Merged
Merged
Stage main2 #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted to prop-types
…a comment about displayAllSteps; got rid of componentDidUpdate because its conditional would never be true
…teraction_steps_edit
…t_id; also adds message.messageservice_sid TODO: migration and schema defining the new indexes desired on message
… message.campaign_contact_id
The deleted test was replaced by __test__/server/api/createOptOut.test.js
… vars This is because AWS Lambda has a max 4K content for environment variables and env vars like GOOGLE_SECRET are >4K by themselves
schuyler1d
added
S-testing-on-stage
Status (ADMINS ONLY): PR label for presence on a staging instance
and removed
S-testing-on-stage
Status (ADMINS ONLY): PR label for presence on a staging instance
labels
Jan 13, 2020
ibrand
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This was referenced Jan 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes everything in #1340 except https://github.com/MoveOnOrg/Spoke/pull/1293/ which had a bug that requires further investigation
This should be the PR for Spoke 5.0. It still needs release notes which should include migration instructions here (for larger instances): https://github.com/MoveOnOrg/Spoke/pull/1311#issuecomment-568786302 (or at least a link to that comment).
@lperson
#1178
#1179
#1344
@SAnschutz
#1277
@jeffm2001
#1306
@schuyler1d
#1311
#1309
#1346
#1351