Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage main2 #1367

Merged
merged 44 commits into from
Jan 14, 2020
Merged

Stage main2 #1367

merged 44 commits into from
Jan 14, 2020

Conversation

schuyler1d
Copy link
Collaborator

@schuyler1d schuyler1d commented Jan 13, 2020

Includes everything in #1340 except https://github.com/MoveOnOrg/Spoke/pull/1293/ which had a bug that requires further investigation

This should be the PR for Spoke 5.0. It still needs release notes which should include migration instructions here (for larger instances): https://github.com/MoveOnOrg/Spoke/pull/1311#issuecomment-568786302 (or at least a link to that comment).

@lperson
#1178
#1179
#1344

@SAnschutz
#1277

@jeffm2001
#1306

@schuyler1d
#1311
#1309
#1346
#1351

lperson and others added 30 commits July 27, 2019 19:36
…a comment about displayAllSteps; got rid of componentDidUpdate because its conditional would never be true
…t_id; also adds message.messageservice_sid

TODO: migration and schema defining the new indexes desired on message
The deleted test was replaced by __test__/server/api/createOptOut.test.js
@ibrand ibrand temporarily deployed to spoke-review-stage-main-jkbvg1 January 13, 2020 18:59 Inactive
@schuyler1d schuyler1d added S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance and removed S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance labels Jan 13, 2020
Copy link
Collaborator

@ibrand ibrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ibrand ibrand merged commit f2d0448 into main Jan 14, 2020
This was referenced Jan 15, 2020
@schuyler1d schuyler1d deleted the stage-main2 branch May 6, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants