You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user (K. Richardson / ANSTO) found some bugs and emailed me about them:
I think I found a couple of very small bugs in the spinw.fitspec method.
The first of these relates to updating the redX2 variable in each consecutive fitting run. I think it might be the case that lines 267 and 273, which read;
redX2(idx) = output.redX2;
Should instead read;
redX2(idx) = output(idx).redX2;
Which would make them the same as line 280. Before these changes the fitspec function was returning a column vector with nRun elements of identical values, whereas after these changes the redX2 output correctly provides different values corresponding to each fitting run.
The second of these is related to displaying the legend in the output plot. Line 451 currently reads;
legend(pHandle(1:2),'simulation','data')
Which was causing two black lines to display in the legend for my data. Changing this line to the following fixed this issue for me.
* Fix bug where imag always plots in auto mode #172
* Allow row vector for hkl for single point #179
* Fix inverted user colormap #131
* Refactor sw_plotspec to avoid recursive calls #132
* Add fitspec fixes suggested by K Richardson #98
* Add spinw obj to spec for twin cases in fitspec #158
* Fix spec spinw object issues in fitmode
spinwave() now creates a .obj field regardless
When fitmode=true, this a barebones struct
When fitmode=false, this is a full spinw object
Fix issue with sw_plotspec when using fastmode/fitmode
Add basic test for fitspec() to check twins handling
* Fix bug in sw_plotspec 'fastmode' handling
* Fix issues from review. Add change log.
A user (K. Richardson / ANSTO) found some bugs and emailed me about them:
I think I found a couple of very small bugs in the
spinw.fitspec
method.The first of these relates to updating the
redX2
variable in each consecutive fitting run. I think it might be the case that lines 267 and 273, which read;Should instead read;
Which would make them the same as line 280. Before these changes the
fitspec
function was returning a column vector with nRun elements of identical values, whereas after these changes theredX2
output correctly provides different values corresponding to each fitting run.The second of these is related to displaying the legend in the output plot. Line 451 currently reads;
Which was causing two black lines to display in the legend for my data. Changing this line to the following fixed this issue for me.
The text was updated successfully, but these errors were encountered: