You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sw_plotspec allows users to specify a colormap with the 'colormap' option but then inverts the scale.
The relevant code is here where it calls sw_multicolor to do the actual plot. However, the final parameter which indicates whether to flip the colormap or not is always set to true. (This is needed for the default color scheme which is an inverted magma colormap, but is annoying for users).
We should change this to either:
Add a new option to flip or not flip the colormap
Just remove the flipping and don't have an option
Keep current behaviour but amend the help file to state that the colormaps will be inverted (!)
I would prefer option 2 (users can flip their colormaps manually before passing to sw_plotspec!). However, in this case we would also need to remove the flipud call in line 434.
The text was updated successfully, but these errors were encountered:
* Fix bug where imag always plots in auto mode #172
* Allow row vector for hkl for single point #179
* Fix inverted user colormap #131
* Refactor sw_plotspec to avoid recursive calls #132
* Add fitspec fixes suggested by K Richardson #98
* Add spinw obj to spec for twin cases in fitspec #158
* Fix spec spinw object issues in fitmode
spinwave() now creates a .obj field regardless
When fitmode=true, this a barebones struct
When fitmode=false, this is a full spinw object
Fix issue with sw_plotspec when using fastmode/fitmode
Add basic test for fitspec() to check twins handling
* Fix bug in sw_plotspec 'fastmode' handling
* Fix issues from review. Add change log.
sw_plotspec
allows users to specify a colormap with the'colormap'
option but then inverts the scale.The relevant code is here where it calls
sw_multicolor
to do the actual plot. However, the final parameter which indicates whether to flip the colormap or not is always set totrue
. (This is needed for the default color scheme which is an invertedmagma
colormap, but is annoying for users).We should change this to either:
I would prefer option 2 (users can flip their colormaps manually before passing to
sw_plotspec
!). However, in this case we would also need to remove theflipud
call in line 434.The text was updated successfully, but these errors were encountered: