fitspec: cannot handle twins #158
Labels
bug
Something isn't working
Comments
mducle
added a commit
that referenced
this issue
Apr 25, 2024
Merged
mducle
added a commit
that referenced
this issue
May 20, 2024
* Fix bug where imag always plots in auto mode #172 * Allow row vector for hkl for single point #179 * Fix inverted user colormap #131 * Refactor sw_plotspec to avoid recursive calls #132 * Add fitspec fixes suggested by K Richardson #98 * Add spinw obj to spec for twin cases in fitspec #158 * Fix spec spinw object issues in fitmode spinwave() now creates a .obj field regardless When fitmode=true, this a barebones struct When fitmode=false, this is a full spinw object Fix issue with sw_plotspec when using fastmode/fitmode Add basic test for fitspec() to check twins handling * Fix bug in sw_plotspec 'fastmode' handling * Fix issues from review. Add change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fitspecis a method to fit the energy and intensity of spin wave modes at specific Q-points (like you would measure using a triple-axis spectrometer).Internally it calls
sw_egridto calculate the scattering intensityswConv. For systems with twins,sw_egridlooks up the twin information in the base spinw obj. However,fitspeccalls the originalspinw/spinwavemethod with thefitmode, trueflag which means that the base spinw object is not included in the spectrum struct.We need to either include the spinw object in the spec struct when there is a twin or find some other way to pass on twin information in the spec struct.
The text was updated successfully, but these errors were encountered: