Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use sdk for procedures #2450

Merged
merged 12 commits into from
Feb 13, 2024
Merged

feat: use sdk for procedures #2450

merged 12 commits into from
Feb 13, 2024

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Jan 31, 2024 •
edited
Loading

updates procedure resource and data source to use SDK
fixes:
#2381
#2291

@github-actions GitHub Actions
Copy link

Integration tests failure for 2d93573761b5f94b5490b3ba2422c07b51d07d5e

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 31, 2024 09:40
sfc-gh-asawicki
sfc-gh-asawicki requested changes Jan 31, 2024
View reviewed changes
docs/resources/procedure.md Show resolved Hide resolved
docs/resources/procedure.md Show resolved Hide resolved
pkg/resources/function.go Outdated Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
pkg/resources/procedure.go Show resolved Hide resolved
pkg/resources/procedure_acceptance_test.go Outdated Show resolved Hide resolved
sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Jan 31, 2024
View reviewed changes
pkg/datasources/procedures.go Show resolved Hide resolved
pkg/datasources/procedures.go Outdated Show resolved Hide resolved
pkg/datasources/procedures.go Outdated Show resolved Hide resolved
pkg/datasources/procedures_acceptance_test.go Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Integration tests failure for 3b8cb2f633e06b16651f4618e0f725d7b6c7053a

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Integration tests failure for 21d8601756ff960f668bdbbb1b20eee2bbb4e03d

sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Feb 7, 2024
View reviewed changes
pkg/datasources/procedures.go Outdated Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review February 8, 2024 12:12
sfc-gh-asawicki
sfc-gh-asawicki requested changes Feb 8, 2024
View reviewed changes
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
pkg/resources/procedure.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Integration tests failure for 2f63d7eef4f21b1e84af881d7f15291f62cb765a

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Integration tests failure for b813938f21214a709617cb7ddcc2798bfa501be5

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Integration tests failure for 118400b83ebcbbbfbf35395e439b8a714b415193

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Integration tests failure for 87a2598468f71cefe586706551c259f78fa29f42

sfc-gh-asawicki
sfc-gh-asawicki requested changes Feb 12, 2024
View reviewed changes
MIGRATION_GUIDE.md Outdated

### Migration from old (grant) resources to new ones
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looked like it was re-written? at the top is a new migration guide intro.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added to point the users to the resource migration guide, I would leave it as it was

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please revert this whole paragraph. Also, TestInt_CreateProcedures is failing, so we cannot merge it yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-added paragraph. Commented out problem in TestInt_CreateProcedures, its an issue I already filed with docs-discuss channel. Included jira ticket in the comment

Copy link
Collaborator Author

@sfc-gh-swinkler sfc-gh-swinkler Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test still failing, but passes locally:

--- PASS: TestInt_CreateProcedures (21.14s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Java:_returns_result_data_type (2.72s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Java:_returns_table (2.44s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Javascript (0.30s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Javascript:_no_arguments (0.24s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Scala:_returns_result_data_type (4.02s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Scala:_returns_table (3.95s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Python:_returns_result_data_type (4.89s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_Python:_returns_table (1.81s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_SQL:_returns_result_data_type (0.42s)
    --- PASS: TestInt_CreateProcedures/create_procedure_for_SQL:_returns_table (0.35s)
PASS

unsure what is going on, going to re-run tests

@github-actions GitHub Actions
Copy link

Integration tests failure for 87a2598468f71cefe586706551c259f78fa29f42

@github-actions GitHub Actions
Copy link

Integration tests failure for 8f022a6711d9ea335429c4725ad012f850290aa6

@github-actions GitHub Actions
Copy link

Integration tests failure for 6ec34037ef579f9e7281961cdd66182b44afb557

@github-actions GitHub Actions
Copy link

Integration tests failure for 9a3c39e6c5550818f8551c156dd4113b812e2216

@github-actions GitHub Actions
Copy link

Integration tests failure for 9a3c39e6c5550818f8551c156dd4113b812e2216

@sfc-gh-asawicki sfc-gh-asawicki merged commit 94ac78a into main Feb 13, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the use-proc branch February 13, 2024 10:55
@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 13, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 15, 2024
@snowflake-release-please
chore(main): release 0.86.0 (#2456)
bde8257 
🤖 I have created a release *beep* *boop*
---


# Release notes
[0.86.0](v0.85.0...v0.86.0)
(2024-02-15)


## 🎉 **What's new**

* add refresh_mode and initialize to dynamic tables
([#2437](#2437))
([d301b20](d301b20))
* add resource snowflake_user_password_policy_attachment
([#2162](#2162))
([#2307](#2307))
([93af462](93af462))
* create a workaround for granting privileges on all pipes
([#2477](#2477))
([64f2346](64f2346))
* Handle IMPORTED PRIVILEGES privileges in privilege-to-role granting
resources
([#2471](#2471))
([eb20051](eb20051))
* use external functions
([#2454](#2454))
([417d473](417d473))
* use funcs from sdk
([#2462](#2462))
([a5f969c](a5f969c))
* use sdk for procedures
([#2450](#2450))
([94ac78a](94ac78a))
* Use sdk in table constraint resource
([#2466](#2466))
([d685603](d685603))
* Use tables from SDK
([#2453](#2453))
([fdb4f88](fdb4f88))


## 🔧 **Misc**

* Add migration notes to the docs and change jira integration
([#2497](#2497))
([b17f1af](b17f1af))
* Change email and issue reporter
([#2470](#2470))
([5865655](5865655))
* Grants migration guide
([#2455](#2455))
([62c70fd](62c70fd))
* Remove unused old implementation from snowflake pkg
([#2458](#2458))
([2d0e508](2d0e508))
* update password policy attachment
([#2485](#2485))
([6ec9ff7](6ec9ff7))


## 🐛 **Bug fixes**

* allow DT warehouse to be updated in-place
([#2439](#2439))
([d565af1](d565af1))
* correct test dependencies
([#2493](#2493))
([dfb247f](dfb247f))
* FileFormat not detecting changes correctly
([#2436](#2436))
([018bb74](018bb74))
* Fix few smaller issues
([#2507](#2507))
([a836871](a836871))
* Fix functions and small other fixes
([#2503](#2503))
([0d4aba4](0d4aba4)),
closes
[#2490](#2490)
* Fix tag tests in view and in materialized view
([#2457](#2457))
([2de942a](2de942a))
* Fix task related issues
([#2479](#2479))
([0385650](0385650))
* Fix tests that base on default data retention
([#2465](#2465))
([682e28c](682e28c))
* grant privileges to share test terraform dependencies
([#2473](#2473))
([ede8d95](ede8d95))
* parameter issues
([#2463](#2463))
([7ee4986](7ee4986))
* parse dynamic table query from DDL
([#2438](#2438))
([d76815c](d76815c))
* Remove title and body temporarily from jira integration
([#2499](#2499))
([672c97d](672c97d))
* SHOW GRANTS mapping for share data type
([#2508](#2508))
([feb4d44](feb4d44))
* user error handling
([#2486](#2486))
([dfa52b2](dfa52b2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@VenelinMartinov VenelinMartinov mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-swinkler @sfc-gh-jcieslak @sfc-gh-asawicki