Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake_procedure not allowed to create secure procedures #2381

Closed
plmnguyen opened this issue Jan 19, 2024 · 2 comments
Closed

snowflake_procedure not allowed to create secure procedures #2381

plmnguyen opened this issue Jan 19, 2024 · 2 comments
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@plmnguyen
Copy link

plmnguyen commented Jan 19, 2024

Terraform CLI and Provider Versions

Terraform v1.5.3
snowflake-labs/snowflake v0.83.1

Terraform Configuration

resource "snowflake_procedure" "calc_phash" {
  name            = "calc_phash"
  database        = "MY_DB"
  schema          = "MY_SCHEMA"
  return_type     = "STRING"
  handler         = "run"
  language        = "python"
  runtime_version = "3.8"
  packages        = ["snowflake-snowpark-python", "imagehash", "pillow"]
  is_secure       = true
  statement       = <<EOT
from PIL import Image
import imagehash
from snowflake.snowpark.files import SnowflakeFile

def run(ignored_session, file_path):
    with SnowflakeFile.open(file_path, 'rb') as f:
        return imagehash.average_hash(Image.open(f))
EOT
}

Expected Behavior

Just as the you can with a snowflake_function, I expected that the is_secure argument should be accepted to created a Secure Procedure. This doesn't allow us to mask sensitive procedures.

Actual Behavior

is_secure is an unsupported argument

│ Error: Unsupported argument
│ 
│   on procedures.tf line 16, in resource "snowflake_procedure" "calc_phash":
│   16:   is_secure       = true
│ 
│ An argument named "is_secure" is not expected here.

Steps to Reproduce

  1. terraform apply

How much impact is this issue causing?

High

Logs

No response

Additional Information

No response

@plmnguyen plmnguyen added the bug Used to mark issues with provider's incorrect behavior label Jan 19, 2024
@plmnguyen
Copy link
Author

May be just a feature request instead, but probably a similar change to allow secure udfs #1574

@sfc-gh-asawicki sfc-gh-asawicki added feature-request Used to mark issues with provider's missing functionalities and removed bug Used to mark issues with provider's incorrect behavior labels Jan 19, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @plmnguyen. Thanks for reporting the issue.

We have plans to redesign all the existing resources (check our newly published ROADMAP). We are migrating this to the new SDK, though, so maybe we will add this missing parameter at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Development

No branches or pull requests

2 participants