Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter issues #2463

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix: parameter issues #2463

merged 3 commits into from
Feb 6, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Feb 5, 2024

Fix for #2353.

Issue 1 - TRANSACTION_ABORT_ON_ERROR couldn't be set

  • I added TRANSACTION_ABORT_ON_ERROR to the available set of parameters and added a test that shows it can be set now

Issue 2 - QUOTED_IDENTIFIERS_IGNORE_CASE couldn't be set because of the invalid syntax produced by our SDK

  • I removed the single_quotes that were causing the invalid syntax error and added a test to prove it works now

@sfc-gh-jcieslak sfc-gh-jcieslak changed the title fix fix: parameter issues Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Integration tests failure for 3f6d8b547692049bfd4400cea3b7bc6fab89e0a5

sfc-gh-swinkler
sfc-gh-swinkler previously approved these changes Feb 5, 2024
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Integration tests failure for 2438a69086bdf6ebf28806a5964d3e8c01e04638

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 7ee4986 into main Feb 6, 2024
6 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the fix-invalid-object-parameters branch February 6, 2024 10:47
Copy link

github-actions bot commented Feb 6, 2024

Integration tests failure for 15b672f311016a5857a6346b75a5ea70973ba38a

sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 15, 2024
🤖 I have created a release *beep* *boop*
---


# Release notes
[0.86.0](v0.85.0...v0.86.0)
(2024-02-15)


## 🎉 **What's new**

* add refresh_mode and initialize to dynamic tables
([#2437](#2437))
([d301b20](d301b20))
* add resource snowflake_user_password_policy_attachment
([#2162](#2162))
([#2307](#2307))
([93af462](93af462))
* create a workaround for granting privileges on all pipes
([#2477](#2477))
([64f2346](64f2346))
* Handle IMPORTED PRIVILEGES privileges in privilege-to-role granting
resources
([#2471](#2471))
([eb20051](eb20051))
* use external functions
([#2454](#2454))
([417d473](417d473))
* use funcs from sdk
([#2462](#2462))
([a5f969c](a5f969c))
* use sdk for procedures
([#2450](#2450))
([94ac78a](94ac78a))
* Use sdk in table constraint resource
([#2466](#2466))
([d685603](d685603))
* Use tables from SDK
([#2453](#2453))
([fdb4f88](fdb4f88))


## 🔧 **Misc**

* Add migration notes to the docs and change jira integration
([#2497](#2497))
([b17f1af](b17f1af))
* Change email and issue reporter
([#2470](#2470))
([5865655](5865655))
* Grants migration guide
([#2455](#2455))
([62c70fd](62c70fd))
* Remove unused old implementation from snowflake pkg
([#2458](#2458))
([2d0e508](2d0e508))
* update password policy attachment
([#2485](#2485))
([6ec9ff7](6ec9ff7))


## 🐛 **Bug fixes**

* allow DT warehouse to be updated in-place
([#2439](#2439))
([d565af1](d565af1))
* correct test dependencies
([#2493](#2493))
([dfb247f](dfb247f))
* FileFormat not detecting changes correctly
([#2436](#2436))
([018bb74](018bb74))
* Fix few smaller issues
([#2507](#2507))
([a836871](a836871))
* Fix functions and small other fixes
([#2503](#2503))
([0d4aba4](0d4aba4)),
closes
[#2490](#2490)
* Fix tag tests in view and in materialized view
([#2457](#2457))
([2de942a](2de942a))
* Fix task related issues
([#2479](#2479))
([0385650](0385650))
* Fix tests that base on default data retention
([#2465](#2465))
([682e28c](682e28c))
* grant privileges to share test terraform dependencies
([#2473](#2473))
([ede8d95](ede8d95))
* parameter issues
([#2463](#2463))
([7ee4986](7ee4986))
* parse dynamic table query from DDL
([#2438](#2438))
([d76815c](d76815c))
* Remove title and body temporarily from jira integration
([#2499](#2499))
([672c97d](672c97d))
* SHOW GRANTS mapping for share data type
([#2508](#2508))
([feb4d44](feb4d44))
* user error handling
([#2486](#2486))
([dfa52b2](dfa52b2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants