Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "The Roman Question" from HPM 0.4.5 #163

Open
wants to merge 1 commit into
base: Development
Choose a base branch
from

Conversation

moretrim
Copy link

@moretrim moretrim commented Jul 13, 2019

The motivation of the original PR arkhometha/Historical-Project-Mod#3:

Add Roman Question follow-up to Il Risorgimento.

Rather than outright hand over all provinces to Italy, send a Roman
Question follow-up event to the Papal States. This gives them an
opportunity to refuse.

The historical Roman Question was a long process. This change does not
reflect that: it is merely a gameplay-oriented, stopgap solution.
Without it PAP eventually faces a functional game-over if Italy hasn't
been formed by decision, as long as any Italian minor is alive no matter
how insignificant.

AI weights ensure a (very) minimal amount of sense, too.

Co-Author: arkhometha [email protected]


This fix (which includes the original PR + upstream changes) has been tested in HPM and this ported PR is diff-neutral with HPM, too.

@moretrim moretrim force-pushed the risorgimento-roman-question branch from a7a9bb6 to a02fbc4 Compare December 9, 2019 14:03
@moretrim moretrim changed the title Port "The Roman Question" from HPM 0.4.5. Port "The Roman Question" from HPM 0.4.5 Dec 9, 2019
@moretrim
Copy link
Author

moretrim commented Dec 9, 2019

I've amended the PR to reflect proper co-authorship.

The motivation of the original PR arkhometha/Historical-Project-Mod#3:

> Add Roman Question follow-up to Il Risorgimento.
>
> Rather than outright hand over all provinces to Italy, send a Roman
Question follow-up event to the Papal States. This gives them an
opportunity to refuse.
>
> The historical Roman Question was a long process. This change does not
reflect that: it is merely a gameplay-oriented, stopgap solution.
Without it PAP eventually faces a functional game-over if Italy hasn't
been formed by decision, as long as any Italian minor is alive no matter
how insignificant.
>
> AI weights ensure a (very) minimal amount of sense, too.

Co-authored-by: arkhometha <[email protected]>
@moretrim moretrim force-pushed the risorgimento-roman-question branch from a02fbc4 to 0ebe349 Compare December 9, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant