-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 #33
Version 2.0.0 #33
Conversation
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Down to minor nits at this point, LGTM otherwise!
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Thanks for the texts edits @ScottBrenner ! I must admit spelling and grammar is not my strong suit so really appreciate the assistance 👍 💯 If this is everything I will let you wait and approve whenever suits you 👍 |
The Action currently installs two additional things beyond the base Lines 16 to 17 in 90f9707
Are these still supported - or even necessary - with these changes? |
Co-authored-by: Scott Brenner <[email protected]>
yes these are still needed 👍 I put them in the code and we do carry out these commands 👍 They pull down the latest and greatest so I left them in 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it! Thank you for the contribution 🙇🏻
|
This reverts commit 15421eb.
This pull request proposes some breaking changes within this GitHub Action.
The main reason for this pull request is:
To release this GitHub Action, we are going to need to make a GitHub Release of
v2
. I think (if possible) we should use versions going forward, just in case someone accidentally pushes to master. I think GitHub Releases are a better approach 👍@ScottBrenner thanks for the chance to make this pull request, it's really appreciated 👍 Really looking forward to your feedback 💯
NOTE
When/If we merge, we should squash these commits into one. For some reason, my
act
wasn't working on my machine so towards the end I had to use GitHub to test 🙃 sorry for that! Let's squash when we go to merge 👍Also @ScottBrenner please feel free to test/contribute any changes you may want 👍