Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 #33

Merged
merged 62 commits into from
Apr 19, 2021
Merged

Version 2.0.0 #33

merged 62 commits into from
Apr 19, 2021

Conversation

NickLiffen
Copy link
Collaborator

This pull request proposes some breaking changes within this GitHub Action.

The main reason for this pull request is:

  • Speed up how quick this GitHub Action Runs.
  • Gives the user more flexibility and freedom when it comes to running this GitHub Action.
  • Adding unit tests to this GitHub Action.

To release this GitHub Action, we are going to need to make a GitHub Release of v2. I think (if possible) we should use versions going forward, just in case someone accidentally pushes to master. I think GitHub Releases are a better approach 👍

@ScottBrenner thanks for the chance to make this pull request, it's really appreciated 👍 Really looking forward to your feedback 💯

NOTE

When/If we merge, we should squash these commits into one. For some reason, my act wasn't working on my machine so towards the end I had to use GitHub to test 🙃 sorry for that! Let's squash when we go to merge 👍

Also @ScottBrenner please feel free to test/contribute any changes you may want 👍

@ScottBrenner ScottBrenner linked an issue Apr 18, 2021 that may be closed by this pull request
Nick Liffen and others added 7 commits April 19, 2021 08:11
Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down to minor nits at this point, LGTM otherwise!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
Nick Liffen and others added 6 commits April 19, 2021 16:07
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
Co-authored-by: Scott Brenner <[email protected]>
@NickLiffen
Copy link
Collaborator Author

Thanks for the texts edits @ScottBrenner ! I must admit spelling and grammar is not my strong suit so really appreciate the assistance 👍 💯 If this is everything I will let you wait and approve whenever suits you 👍

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@ScottBrenner
Copy link
Owner

The Action currently installs two additional things beyond the base cfn-lint

RUN cfn-lint --update-specs
RUN cfn-lint --update-iam-policies

Are these still supported - or even necessary - with these changes?

Co-authored-by: Scott Brenner <[email protected]>
@NickLiffen
Copy link
Collaborator Author

The Action currently installs two additional things beyond the base cfn-lint

RUN cfn-lint --update-specs
RUN cfn-lint --update-iam-policies

Are these still supported - or even necessary - with these changes?

yes these are still needed 👍 I put them in the code and we do carry out these commands 👍 They pull down the latest and greatest so I left them in 👍

@NickLiffen NickLiffen requested a review from ScottBrenner April 19, 2021 16:24
Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Let's do it! Thank you for the contribution 🙇🏻

@ScottBrenner ScottBrenner merged commit 15421eb into ScottBrenner:master Apr 19, 2021
@ScottBrenner
Copy link
Owner

ScottBrenner added a commit that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Custom Lint Files Feature: Config file
3 participants