Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Problem Matchers #40

Closed
ScottBrenner opened this issue Apr 19, 2021 · 2 comments · Fixed by #43
Closed

feat: Problem Matchers #40

ScottBrenner opened this issue Apr 19, 2021 · 2 comments · Fixed by #43
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ScottBrenner
Copy link
Owner

ScottBrenner commented Apr 19, 2021

4e7c712 previously introduced Problem Matchers to this Action, but this functionality was removed with 15421eb#diff-efc0e1791ad6067603d6250b9eca6bfa0159eb4f7ce6f65b5ffd68273a179117.

As discussed in https://github.com/ScottBrenner/cfn-lint-action/pull/33/files#r615433016:

From https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md
Problem Matchers are a way to scan the output of actions for a specified regex pattern and surface that information prominently in the UI

This will display linting errors inline on pull requests, see the image in https://github.com/ScottBrenner/cfn-lint-action#github-action-for-cloudformation-linter https://github.com/ScottBrenner/cfn-lint-action/blob/90f970711aa1b19575dd9522d2340c5bca6df803/screenshot.png for an example.

Might have to defer to original implementor @softprops regarding functionality, but in addition to this cfn-lint.json file we'll need something similar to 4e7c712#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2R7 looks like.

@ScottBrenner ScottBrenner added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 19, 2021
@softprops
Copy link
Contributor

Good question. I actually didn't know what this done. We could get this working again by simply adding the file back in and it would honour the files existence and the cfn-lint package would use it. However, I honestly didn't know what this was 🤔 @ScottBrenner could you explain? If it's needed all we need to do it re-commit it back in to the root of the action and copy it over to the $PATH I think

aw shucks this was really useful. I can take a look at this again

we managed installing this before with an echo command but we should be able to do it in the update java script example as well. Here's an example from the setup-python action

@NickLiffen
Copy link
Collaborator

NickLiffen commented Apr 19, 2021

I am happy to take a look at this btw if you need 👍 I don't really know what it does but happy to help to get it done if required 👍 Or happy to review something if anyone else wants to give it a go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants