Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Introduction of Problem Matchers #43

Merged
merged 10 commits into from
Apr 20, 2021
Merged

Re-Introduction of Problem Matchers #43

merged 10 commits into from
Apr 20, 2021

Conversation

NickLiffen
Copy link
Collaborator

Closes #40

@NickLiffen
Copy link
Collaborator Author

I intend for #38 to get merged before 👍 Hence why I have updated the release for this to be a v2.1.0 and #38 to be v2.0.1 👍 Just FYI.

@NickLiffen
Copy link
Collaborator Author

@ScottBrenner I realised the v2 release changed the name of this GitHub Action. Now links that people have put to this GitHub Action no longer work, so I have reverted it back to the previous name 👍

@ScottBrenner ScottBrenner added enhancement New feature or request javascript Pull requests that update Javascript code documentation Improvements or additions to documentation labels Apr 20, 2021
@ScottBrenner
Copy link
Owner

Oops, yeah see it under https://github.com/marketplace/actions/setup-aws-cfn-lint now 😄

ScottBrenner
ScottBrenner reviewed Apr 20, 2021
View reviewed changes
dist/index.js Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ScottBrenner
Copy link
Owner

cc: @softprops 😁

@NickLiffen
Copy link
Collaborator Author

@ScottBrenner this PR is ready for merge and review 👍

I am checking off for the evening (I am based in the UK). For some reason, it wouldn't let me push tags to this repository 🤔 It would be great to get both this PR and #38 out. Is there any chance you could merge and release both releases if you get time, please? (remember we would also need to update v2 manually as we need to automate that).

If you could get round to this, it would be appreciated 👍

Thanks again for your reviews and help!

@NickLiffen NickLiffen marked this pull request as ready for review April 20, 2021 17:13
@NickLiffen NickLiffen requested a review from ScottBrenner April 20, 2021 17:13
ScottBrenner
ScottBrenner approved these changes Apr 20, 2021
View reviewed changes
Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ScottBrenner ScottBrenner merged commit 3e2d72a into main Apr 20, 2021
@ScottBrenner ScottBrenner deleted the feature/problem-matchers branch April 20, 2021 17:32
@ScottBrenner
Copy link
Owner

@softprops
Copy link
Contributor

thanks folks 👏

@softprops
Copy link
Contributor

softprops commented Apr 20, 2021 •
edited
Loading

I just upgraded this action at work and verified the problem matchers. This works great!

@ScottBrenner ScottBrenner mentioned this pull request Apr 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottBrenner ScottBrenner ScottBrenner approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Problem Matchers
3 participants
@NickLiffen @ScottBrenner @softprops