Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom Lint Files #27

Closed
NickLiffen opened this issue Feb 22, 2021 · 8 comments · Fixed by #33
Closed

Feature: Custom Lint Files #27

NickLiffen opened this issue Feb 22, 2021 · 8 comments · Fixed by #33
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@NickLiffen
Copy link
Collaborator

As a developer, I would like to append custom rules to this action, so I can run specific actions that are only applicable to the company I work for.

In a perfect work, I would be able to specify the repository, ref (branch) and path 💯

@ScottBrenner ScottBrenner added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 22, 2021
@NickLiffen
Copy link
Collaborator Author

@ScottBrenner 👋 How open would you be to a slight restructuring of the architecture of this application? Right now it's all in oneDockerfile`, I can see us expanding outside to use something like this.

It would mean we could add some unit tests and also have some more luxury with the GitHub Octokit Library. E.G in this issue, I can reference other repositories outside the scope of the action it runs in.

I am happy to do the work, but understand you are the maintainer so would like your thoughts.

Personally, everything in the Dockerfile somewhat limits us a bit with the potential of this action. However, your thoughts would be great 👍

@NickLiffen
Copy link
Collaborator Author

NickLiffen commented Feb 23, 2021

Again, I would be happy to do the work, or we could collaborate together 💯

The cloud formation linter has great config options, and I think we could honour that better with the JS Option over native Dockerfile. Thanks. Happy to chat about it in this issue if you like.

@ScottBrenner
Copy link
Owner

Let's do it! I've no experience developing in JavaScript unfortunately so I wouldn't be able to assist much, but I'm certainly open to it.

@NickLiffen
Copy link
Collaborator Author

Thanks @ScottBrenner 💯 Could you assign me write access, please? It's easier to test in this repo, you can protect the master branch and assign reviews to make sure you review before anything goes in 👍 If that's okay, would be a little easier then forking? Thanks 👍

@ScottBrenner
Copy link
Owner

Sure, but what's the advantage of working in this repository over a fork? not familiar myself

@NickLiffen
Copy link
Collaborator Author

Sory @ScottBrenner I am just getting to this 👍 I am ready to raise a pull request if you are good to review 👍 ?

@ScottBrenner
Copy link
Owner

Sure! 👍🏻

@NickLiffen
Copy link
Collaborator Author

@ScottBrenner pull request raised 👍 would love your feedback 🌷

@ScottBrenner ScottBrenner linked a pull request Apr 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants