Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo's in Gitwash. #5145

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fixing typo's in Gitwash. #5145

merged 2 commits into from
Feb 3, 2023

Conversation

HGWright
Copy link
Contributor

@HGWright HGWright commented Feb 1, 2023

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard @HGWright 🥳

This PR looks good to me. Thanks for your first (of many 😉) contribution to iris!

I think that it's totally appropriate for you to add an entry to the whatsnew latest.rst. In particular,

  • to the Announcements section, highlighting that this is your first contribution (see the first entry here in the iris v3.4.0 release whatsnew, as an example)
  • to the Documentation section, detailing your change. Simply follow the style guide and format of other existing entries

Lookin' forward to banking this PR 😄

@bjlittle
Copy link
Member

bjlittle commented Feb 3, 2023

@HGWright As you aren't an iris core developer yet, you need to add an entry at the bottom of the latest.rst to resolve the link to our GH user i.e.,

.. comment
    Whatsnew author names (@github name) in alphabetical order. Note that,
    core dev names are automatically included by the common_links.inc:

.. _@HGWright: https://github.com/HGWright                     <------ add this here

If you don't do this, then you'll find that your user name is a broken link. Confirm this is the case by building the docs and viewing the latest.rst before and after you make this change.

@trexfeathers
Copy link
Contributor

@HGWright As you aren't an iris core developer yet, you need to add and entry at the bottom of the latest.rst to resolve the link to our GH user i.e.,

.. comment
    Whatsnew author names (@github name) in alphabetical order. Note that,
    core dev names are automatically included by the common_links.inc:

.. _@HGWright: https://github.com/HGWright                     <------ add this here

If you don't do this, then you'll find that your user name is a broken link. Confirm this is the case by building the docs and viewing the latest.rst before and after you make this change.

That's my bad @bjlittle! @HGWright asked me and I encouraged him to put the link into common_links.inc. I think we put @ESadek-MO there before he was a core dev, too. Do you reckon this method is a problem?

@bjlittle
Copy link
Member

bjlittle commented Feb 3, 2023

That's my bad @bjlittle! @HGWright asked me and I encouraged him to put the link into common_links.inc. I think we put @ESadek-MO there before he was a core dev, too. Do you reckon this method is a problem?

No worries, all good. Yup, my eye glazed over that entry. I'm happy if you are. All good 😄

@bjlittle bjlittle merged commit 7da248c into SciTools:main Feb 3, 2023
@bjlittle
Copy link
Member

bjlittle commented Feb 3, 2023

@HGWright Nice one! 🥳

@HGWright HGWright deleted the dev branch February 3, 2023 16:47
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
* upstream/main: (23 commits)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084)
  removed cell measure mask check and error (SciTools#5181)
  Updated environment lockfiles (SciTools#5177)
  Lazy weighted RMS calculation (SciTools#5017)
  Add coverage badge to README.md (SciTools#5176)
  Add coverage testing (SciTools#4765)
  Whats new updates for v3.4.1 .
  NetCDF thread safety take two (SciTools#5095)
  Updated environment lockfiles (SciTools#5163)
  Plugin support (SciTools#5144)
  Expand scope of common contributor links (SciTools#5159)
  Replace apparently retired UDUNITS documentation link. (SciTools#5153)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5150)
  Fixing typo's in Gitwash. (SciTools#5145)
  add readme #showyourstripes (SciTools#5141)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5143)
  Iris ❤ Xarray docs page. (SciTools#5025)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5136)
  Updated citation (SciTools#5116)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants