Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin support #5144

Merged
merged 11 commits into from
Feb 15, 2023
Merged

Plugin support #5144

merged 11 commits into from
Feb 15, 2023

Conversation

vsherratt
Copy link
Contributor

🚀 Pull Request

Plugins! cf #4798 and the older proof of concept #3657.

It uses the same approach of namespace packages, but as iris.plugins instead of limiting ourselves to iris.io.plugins, and does not try to discover which plugins are available (should it..?)

This has been successfully used to separate out the NAME loader, although that will be a separate PR once we're happy with the approach to plugins.


Consult Iris pull request check list

@trexfeathers trexfeathers self-assigned this Feb 8, 2023
@trexfeathers trexfeathers requested a review from pp-mo February 8, 2023 10:31
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @bsherratt, very exciting!

A few documentation suggestions for you.

lib/iris/plugins/README.md Show resolved Hide resolved
lib/iris/__init__.py Show resolved Hide resolved
lib/iris/__init__.py Show resolved Hide resolved
docs/src/community/index.rst Outdated Show resolved Hide resolved
docs/src/community/index.rst Outdated Show resolved Hide resolved
docs/src/community/index.rst Outdated Show resolved Hide resolved
docs/src/community/index.rst Show resolved Hide resolved
@trexfeathers
Copy link
Contributor

I expect this will need #5153 before the CI will pass.

@trexfeathers
Copy link
Contributor

trexfeathers commented Feb 10, 2023

I'm good for this to be merged, but I know @pp-mo wanted a look first

@pp-mo
Copy link
Member

pp-mo commented Feb 15, 2023

I'm good for this to be merged, but I know @pp-mo wanted a look first

Thanks for the reminder.
I've now looked it over and I must say 👍 ❤️ 😁 all round
Please merge !!

@pp-mo
Copy link
Member

pp-mo commented Feb 15, 2023

Please merge !!

( Once there is a whatsnew item ! )

@vsherratt
Copy link
Contributor Author

Once there is a whatsnew item

Now added, including an entry in common_links, because actually I was convinced that I was already there from previous contributions but apparently not 🤷

@trexfeathers trexfeathers merged commit 504c188 into SciTools:main Feb 15, 2023
@vsherratt vsherratt deleted the plugins branch February 15, 2023 15:17
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
* upstream/main: (23 commits)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084)
  removed cell measure mask check and error (SciTools#5181)
  Updated environment lockfiles (SciTools#5177)
  Lazy weighted RMS calculation (SciTools#5017)
  Add coverage badge to README.md (SciTools#5176)
  Add coverage testing (SciTools#4765)
  Whats new updates for v3.4.1 .
  NetCDF thread safety take two (SciTools#5095)
  Updated environment lockfiles (SciTools#5163)
  Plugin support (SciTools#5144)
  Expand scope of common contributor links (SciTools#5159)
  Replace apparently retired UDUNITS documentation link. (SciTools#5153)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5150)
  Fixing typo's in Gitwash. (SciTools#5145)
  add readme #showyourstripes (SciTools#5141)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5143)
  Iris ❤ Xarray docs page. (SciTools#5025)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5136)
  Updated citation (SciTools#5116)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants