Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iris ❤ Xarray docs page. #5025

Merged
merged 14 commits into from
Jan 24, 2023
Merged

Iris ❤ Xarray docs page. #5025

merged 14 commits into from
Jan 24, 2023

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Oct 13, 2022 •
edited
Loading

🚀 Pull Request

Description

As well as creating the page, this Pull Request adds a new Community section to the docs, where this page can live together with other information/links about getting involved and how we relate to other projects.

To-do

  • Do links
  • Detail on times and fill values @pp-mo
    @pp-mo is busy, so using a to-do comment for now (d3c83b1)
  • Consistent styling
  • What's New entry
  • Overall summary of the different experience?
  • Better location? / Make Technical Papers more visible?
    New Community section

Future additions

  • Glossary translating Iris & Xarray terms
  • Comparison - Arithmetic
  • Comparison - Metadata
  • Comparison - Subsetting/Slicing

Consult Iris pull request check list

@trexfeathers trexfeathers mentioned this pull request Dec 2, 2022
Closed
@trexfeathers
Copy link
Contributor Author

  • Detail on times and fill values @pp-mo

@pp-mo this is getting close now I think. Are you able to produce this extra detail that you wanted to?

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Dec 15, 2022 •
edited
Loading

@dcherian would you or any other Xarray devs care to look at this proposed documentation page: Iris ❤ Xarray?

We like how Xarray mentions other similar packages in the documentation, so we wanted to do the same.

dcherian
dcherian reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers. I left a couple of comments. I'll ping the core team to take a look.

(apologies for the delay, i've been traveling)

docs/src/techpapers/iris_xarray.rst Outdated Show resolved Hide resolved
docs/src/techpapers/iris_xarray.rst Outdated Show resolved Hide resolved
docs/src/techpapers/iris_xarray.rst Outdated Show resolved Hide resolved
docs/src/techpapers/iris_xarray.rst Outdated Show resolved Hide resolved
@shoyer
Copy link
Contributor

shoyer commented Dec 20, 2022

The guide looks great, thank you. I think Deepak noticed most of the important issues.

I also wanted to say thanks for Iris. It was definitely a big part of the inspiration for Xarray.

@trexfeathers trexfeathers marked this pull request as ready for review January 19, 2023 15:44
@bjlittle bjlittle self-requested a review January 24, 2023 09:49
bjlittle
bjlittle requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Awesome, love it!

Just some super minor comments and suggestions to service, otherwise let's get this banked 👍

docs/src/community/index.rst Outdated Show resolved Hide resolved
docs/src/community/index.rst Outdated Show resolved Hide resolved
docs/src/community/iris_xarray.rst Outdated Show resolved Hide resolved
@bjlittle bjlittle merged commit 4a945ec into SciTools:main Jan 24, 2023
@trexfeathers
Copy link
Contributor Author

Thanks @bjlittle, and everyone for their contributions!

@trexfeathers trexfeathers deleted the iris_xarray branch February 24, 2023 13:53
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
@tkknight
Merge remote-tracking branch 'upstream/main' into dark_theme
c1e6e47 
* upstream/main: (23 commits)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084)
  removed cell measure mask check and error (SciTools#5181)
  Updated environment lockfiles (SciTools#5177)
  Lazy weighted RMS calculation (SciTools#5017)
  Add coverage badge to README.md (SciTools#5176)
  Add coverage testing (SciTools#4765)
  Whats new updates for v3.4.1 .
  NetCDF thread safety take two (SciTools#5095)
  Updated environment lockfiles (SciTools#5163)
  Plugin support (SciTools#5144)
  Expand scope of common contributor links (SciTools#5159)
  Replace apparently retired UDUNITS documentation link. (SciTools#5153)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5150)
  Fixing typo's in Gitwash. (SciTools#5145)
  add readme #showyourstripes (SciTools#5141)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5143)
  Iris ❤ Xarray docs page. (SciTools#5025)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5136)
  Updated citation (SciTools#5116)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

@bjlittle bjlittle bjlittle approved these changes

Assignees

@trexfeathers trexfeathers

Labels
Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trexfeathers @shoyer @bjlittle @dcherian