Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauss Newton with Line Search #268

Merged
merged 7 commits into from
Nov 5, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 1, 2023

TODOs

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #268 (77be3a2) into master (b8d43a3) will increase coverage by 45.16%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #268       +/-   ##
===========================================
+ Coverage   48.41%   93.58%   +45.16%     
===========================================
  Files          19       19               
  Lines        1801     1807        +6     
===========================================
+ Hits          872     1691      +819     
+ Misses        929      116      -813     
Files Coverage Δ
src/gaussnewton.jl 77.27% <100.00%> (+14.91%) ⬆️
src/linesearch.jl 88.05% <100.00%> (+82.79%) ⬆️
src/raphson.jl 100.00% <ø> (+26.98%) ⬆️
src/utils.jl 85.54% <ø> (+33.22%) ⬆️

... and 14 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@vpuri3
Copy link
Member

vpuri3 commented Nov 1, 2023

Any reason to not use LineSearches.jl?

@avik-pal
Copy link
Member Author

avik-pal commented Nov 1, 2023

It is using LineSearches internally

@avik-pal avik-pal changed the title [WIP] Gauss Newton with Line Search Gauss Newton with Line Search Nov 1, 2023
@avik-pal avik-pal marked this pull request as ready for review November 1, 2023 19:51
@avik-pal
Copy link
Member Author

avik-pal commented Nov 1, 2023

This is done. just need the previous PRs to be merged

Manifest.toml Outdated Show resolved Hide resolved
@vpuri3
Copy link
Member

vpuri3 commented Nov 2, 2023

would it be possible to pass an initial guess for alpha and line search? example? InitialStatic(), InitialPrevious(), etc...

@avik-pal
Copy link
Member Author

avik-pal commented Nov 2, 2023

would it be possible to pass an initial guess for alpha and line search? example? InitialStatic(), InitialPrevious(), etc...

Not currently. I have no clue how that API currently works.

@ChrisRackauckas ChrisRackauckas merged commit 4f1676c into SciML:master Nov 5, 2023
10 of 11 checks passed
@avik-pal avik-pal deleted the ap/gn_linesearch branch November 5, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants