-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper handling of complex numbers and failures #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fixes
branch
2 times, most recently
from
October 27, 2023 16:54
2d4a88d
to
19fb541
Compare
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 19 19
Lines 1744 1754 +10
======================================
- Misses 1744 1754 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
15 tasks
ChrisRackauckas
approved these changes
Oct 28, 2023
avik-pal
changed the title
Proper handling of complex numbers and failures
[WIP] Proper handling of complex numbers and failures
Oct 28, 2023
avik-pal
force-pushed
the
ap/fixes
branch
2 times, most recently
from
October 29, 2023 13:48
b110e05
to
a3c8951
Compare
Builds off JuliaDiff/SparseDiffTools.jl#271 & SciML/DiffEqBase.jl#954 |
avik-pal
force-pushed
the
ap/fixes
branch
3 times, most recently
from
October 31, 2023 15:36
0a25750
to
23b4e74
Compare
avik-pal
changed the title
[WIP] Proper handling of complex numbers and failures
Proper handling of complex numbers and failures
Nov 1, 2023
@ChrisRackauckas this should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
__findmin
ignores NaNsConvergenceFailure
if it stops due to shrinkingTODO