Rework the Termination Condition API to be type stable #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
avik-pal
force-pushed
the
ap/tstable_termination
branch
from
66ec194 to
0b4d3fa
Compare
avik-pal
force-pushed
the
ap/tstable_termination
branch
from
0b4d3fa to
8fccdcc
Compare
avik-pal
changed the title
|
This should be good to go once the NonlinearSolve PR tests pass |
avik-pal
force-pushed
the
ap/tstable_termination
branch
from
7b4f511 to
43206a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leads to quite a bit of type instability in the cache of the NonlinearSolve Algorithms. I will prototype a version there as well to see if this fixes things!