Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Termination Condition API to be type stable #954

Merged
merged 8 commits into from
Oct 31, 2023

Cancel intermediate builds

43206a7
Select commit
Loading
Failed to load commit list.
Merged

Rework the Termination Condition API to be type stable #954

Cancel intermediate builds
43206a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 31, 2023 in 0s

3.48% of diff hit (target 65.72%)

View this Pull Request on Codecov

3.48% of diff hit (target 65.72%)

Annotations

Check warning on line 206 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L204-L206 

Added lines #L204 - L206 were not covered by tests

Check warning on line 211 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L208-L211 

Added lines #L208 - L211 were not covered by tests

Check warning on line 213 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L213 

Added line #L213 was not covered by tests

Check warning on line 218 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L217-L218 

Added lines #L217 - L218 were not covered by tests

Check warning on line 223 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L220-L223 

Added lines #L220 - L223 were not covered by tests

Check warning on line 226 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L226 

Added line #L226 was not covered by tests

Check warning on line 232 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L229-L232 

Added lines #L229 - L232 were not covered by tests

Check warning on line 236 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L234-L236 

Added lines #L234 - L236 were not covered by tests

Check warning on line 238 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L238 

Added line #L238 was not covered by tests

Check warning on line 242 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L241-L242 

Added lines #L241 - L242 were not covered by tests

Check warning on line 246 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L244-L246 

Added lines #L244 - L246 were not covered by tests

Check warning on line 248 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L248 

Added line #L248 was not covered by tests

Check warning on line 257 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L256-L257 

Added lines #L256 - L257 were not covered by tests

Check warning on line 259 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L259 

Added line #L259 was not covered by tests

Check warning on line 261 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L261 

Added line #L261 was not covered by tests

Check warning on line 263 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L263 

Added line #L263 was not covered by tests

Check warning on line 266 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L266 

Added line #L266 was not covered by tests

Check warning on line 270 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L268-L270 

Added lines #L268 - L270 were not covered by tests

Check warning on line 272 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L272 

Added line #L272 was not covered by tests

Check warning on line 274 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L274 

Added line #L274 was not covered by tests

Check warning on line 278 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L278 

Added line #L278 was not covered by tests

Check warning on line 281 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L280-L281 

Added lines #L280 - L281 were not covered by tests

Check warning on line 285 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L285 

Added line #L285 was not covered by tests

Check warning on line 288 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L287-L288 

Added lines #L287 - L288 were not covered by tests

Check warning on line 294 in src/termination_conditions.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/termination_conditions.jl#L292-L294 

Added lines #L292 - L294 were not covered by tests
View more details on Codecov