Skip to content

Commit

Permalink
Try fixing linesearch
Browse files Browse the repository at this point in the history
  • Loading branch information
avik-pal committed Nov 1, 2023
1 parent e6a72d3 commit d147b77
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/linesearch.jl
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ function LineSearchesJLCache(ls::LineSearch, f::F, u, p, fu1, IIP::Val{iip}) whe
end

function g!(u, fu)
# FIXME: Upstream patch to allow non-square Jacobians
op = VecJac((args...) -> f(args..., p), u; autodiff)
op = VecJac(f.f, u, p; autodiff)

Check warning on line 125 in src/linesearch.jl

View check run for this annotation

Codecov / codecov/patch

src/linesearch.jl#L125

Added line #L125 was not covered by tests
if iip
mul!(g₀, op, fu)
return g₀
Expand Down

0 comments on commit d147b77

Please sign in to comment.