-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix dev script of all packages to use turborepo #2058
Conversation
|
What about putting a command in the workspace root instead of having to maintain it in all |
I like the idea. Did you get it to work? If I do this, turbo tells me that no workspaces/packages have been found and nothing is run |
Weird, I am pretty sure I got it to work with the root script. But I also jumped between versions... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, can't we use pnpm
? https://pnpm.io/filtering#--filter-package_name-4
Relates to #1951
Currently our dev scripts (e.g. of
sit-onyx
) do not work in a clean repository. The issue is thatsit-onyx
depends on other packages (like icons) to be build first.I aligned all
dev
scripts for all packages to be run with turborepo so all dependencies are managed/build correctly.