Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dev script of all packages to use turborepo #2058

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

larsrickert
Copy link
Collaborator

Relates to #1951

Currently our dev scripts (e.g. of sit-onyx) do not work in a clean repository. The issue is that sit-onyx depends on other packages (like icons) to be build first.

I aligned all dev scripts for all packages to be run with turborepo so all dependencies are managed/build correctly.

@larsrickert larsrickert requested a review from a team as a code owner November 7, 2024 13:37
Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: d915ea9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 self-assigned this Nov 7, 2024
@JoCa96
Copy link
Collaborator

JoCa96 commented Nov 7, 2024

What about putting a command in the workspace root instead of having to maintain it in all package.json files:
turbo watch xx:xx --filter=.
This would then be called using pnpm -w dev in the respective workspace.

apps/demo-app/package.json Outdated Show resolved Hide resolved
@larsrickert
Copy link
Collaborator Author

What about putting a command in the workspace root instead of having to maintain it in all package.json files: turbo watch xx:xx --filter=. This would then be called using pnpm -w dev in the respective workspace.

I like the idea. Did you get it to work? If I do this, turbo tells me that no workspaces/packages have been found and nothing is run

@larsrickert larsrickert requested a review from JoCa96 November 7, 2024 15:26
@JoCa96
Copy link
Collaborator

JoCa96 commented Nov 8, 2024

What about putting a command in the workspace root instead of having to maintain it in all package.json files: turbo watch xx:xx --filter=. This would then be called using pnpm -w dev in the respective workspace.

I like the idea. Did you get it to work? If I do this, turbo tells me that no workspaces/packages have been found and nothing is run

Weird, I am pretty sure I got it to work with the root script. But I also jumped between versions...
But the following works as a workspace specific script:
"dev": "turbo run turbo:dev --filter=.",
So maybe we can use that so we don't have to filter by package name.

apps/docs/package.json Outdated Show resolved Hide resolved
@larsrickert larsrickert requested a review from JoCa96 November 8, 2024 11:12
@JoCa96 JoCa96 self-requested a review November 8, 2024 11:41
Copy link
Collaborator

@JoCa96 JoCa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsrickert larsrickert merged commit e198c90 into main Nov 8, 2024
19 checks passed
@larsrickert larsrickert deleted the chore/fix-turborepo-scripts branch November 8, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants