Skip to content

Commit

Permalink
chore: fix dev script of all packages to use turborepo (#2058)
Browse files Browse the repository at this point in the history
Relates to #1951 

Currently our dev scripts (e.g. of `sit-onyx`) do not work in a clean
repository. The issue is that `sit-onyx` depends on other packages (like
icons) to be build first.

I aligned all `dev` scripts for all packages to be run with turborepo so
all dependencies are managed/build correctly.
  • Loading branch information
larsrickert authored Nov 8, 2024
1 parent b9fc6e4 commit e198c90
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 15 deletions.
4 changes: 2 additions & 2 deletions apps/demo-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"version": "1.0.0-beta.63",
"type": "module",
"scripts": {
"dev": "turbo run vite --filter demo-app",
"vite": "vite",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "vite",
"build": "vue-tsc && vite build",
"preview": "vite preview"
},
Expand Down
3 changes: 2 additions & 1 deletion apps/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"type": "module",
"private": true,
"scripts": {
"dev": "VITEPRESS_SKIP_GITHUB_FETCH=true vitepress dev src",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "VITEPRESS_SKIP_GITHUB_FETCH=true vitepress dev src",
"build": "pnpm run '/type-check|build-only/'",
"build-only": "vitepress build src",
"type-check": "vue-tsc --noEmit",
Expand Down
4 changes: 2 additions & 2 deletions apps/playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"private": true,
"homepage": "https://playground.onyx.schwarz",
"scripts": {
"dev": "turbo run vite --filter playground",
"vite": "vite",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "vite",
"preview": "vite preview",
"build": "pnpm run '/type-check|build-only/'",
"build-only": "vite build",
Expand Down
3 changes: 2 additions & 1 deletion packages/chartjs-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"url": "https://github.com/SchwarzIT/onyx/issues"
},
"scripts": {
"dev": "storybook dev -p 6006 --no-open",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "storybook dev -p 6006 --no-open",
"build": "vue-tsc --noEmit",
"test": "vitest",
"test:coverage": "vitest run --coverage",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"dist"
],
"scripts": {
"dev": "nuxi dev playground",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "nuxi dev playground",
"dev:build": "nuxi build playground",
"dev:prepare": "nuxt-module-build build --stub && nuxt-module-build prepare && nuxi prepare playground",
"build": "pnpm run dev:prepare && nuxt-module-build build",
Expand Down
4 changes: 2 additions & 2 deletions packages/sit-onyx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"url": "https://github.com/SchwarzIT/onyx/issues"
},
"scripts": {
"td": "turbo watch --filter=sit-onyx dev",
"dev": "storybook dev -p 6006 --no-open",
"dev": "turbo run turbo:dev --filter=.",
"turbo:dev": "storybook dev -p 6006 --no-open",
"build": "vite build && vue-tsc -p tsconfig.app.json --composite false",
"build:storybook": "storybook build",
"preview": "vite serve storybook-static",
Expand Down
7 changes: 1 addition & 6 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@
"dependsOn": ["sit-onyx#build", "build"],
"outputs": ["playwright-report", "test-results"]
},
"dev": {
"dependsOn": ["^build"],
"cache": false,
"persistent": true
},
"vite": {
"turbo:dev": {
"dependsOn": ["^build"],
"cache": false,
"persistent": true
Expand Down

0 comments on commit e198c90

Please sign in to comment.