chore: fix cyclic dependencies #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5468797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ChristianBusshoff
changed the title
…thub.com/SchwarzIT/onyx into feat/1713-removal-of-cyclic-dependencies
…` now expects a new first parameter which requires brand details to be set
…13-removal-of-cyclic-dependencies
JoCa96
changed the title
larsrickert
requested changes
Nov 6, 2024
…13-removal-of-cyclic-dependencies
larsrickert
requested changes
Nov 7, 2024
Co-authored-by: Lars Rickert <[email protected]>
…thub.com/SchwarzIT/onyx into feat/1713-removal-of-cyclic-dependencies
…13-removal-of-cyclic-dependencies
JoCa96
force-pushed
the
feat/1713-removal-of-cyclic-dependencies
branch
from
16a59b5
to
0c16c24
Compare
larsrickert
requested changes
Nov 7, 2024
larsrickert
approved these changes
Nov 7, 2024
larsrickert
added a commit
that referenced
this pull request
Nov 8, 2024
Relates to #1951 Currently our dev scripts (e.g. of `sit-onyx`) do not work in a clean repository. The issue is that `sit-onyx` depends on other packages (like icons) to be build first. I aligned all `dev` scripts for all packages to be run with turborepo so all dependencies are managed/build correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.css, which is already exported asstyles.cssto have the same name internallysit-onyxdependency:getComputedStyle(el).getPropertyValue(property)branddefaults forcreateThemeto keep users from using our brand detailsONYX_BREAKPOINTSconstant andOnyxBreakpointtype to@sit-onyx/shared@sit-onyx/sharedis now published as we have direct build and runtime dependencies to itturboconfiguration has been updated, so that it builds shared beforehandturboto determine dependencies itselfpeerDependenciesfrom the workspace intodevDependenciesasturbowill not consider them otherwise (See also: vercel/turborepo@1eb3333)sass-embeddedto fix incompatible vite plugin types (different version usages ofsass-embeddedwill result in dedicatedvitedependencies and therefore inequal types)