Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDA: Infer column type from Runner #994

Closed
SmiteDeluxe opened this issue Apr 5, 2024 · 2 comments · Fixed by #1182
Closed

EDA: Infer column type from Runner #994

SmiteDeluxe opened this issue Apr 5, 2024 · 2 comments · Fixed by #1182
Assignees
@SmiteDeluxe
Labels
released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension

Comments

@SmiteDeluxe
Copy link
Contributor

At the moment the type of columns in my state Object is interpreted from the type of the value in the first row. Change this to get it from the Runner to be consistent with that.
@SmiteDeluxe SmiteDeluxe added the vscode 🔨 Issues regarding tools like the VS Code extension label Apr 5, 2024
@SmiteDeluxe SmiteDeluxe self-assigned this Apr 5, 2024
@SmiteDeluxe SmiteDeluxe added this to DSL Apr 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Apr 5, 2024
@lars-reimann
Copy link
Member

Related to #37.

@SmiteDeluxe SmiteDeluxe mentioned this issue May 27, 2024
Merged
@SmiteDeluxe SmiteDeluxe linked a pull request May 27, 2024 that will close this issue
feat: infer column type from runner #1182
Merged
lars-reimann pushed a commit that referenced this issue May 28, 2024
@SmiteDeluxe
feat: infer column type using runner (#1182)
846f404 
Closes #994 

### Summary of Changes

EDA adds another execution in getting the Table placeholder to get
column types with the .getColumn().isNumeric call that based on that
evals to numeric or categorical type. In future also consider the
temporal type, but will have to overhaul the profiling and filters for
that.
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in DSL May 28, 2024
lars-reimann pushed a commit that referenced this issue May 29, 2024
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
4c93458 
## [0.17.0](v0.16.1...v0.17.0) (2024-05-29)

### Features

* hide columns in EDA ([#1181](#1181)) ([15ccaac](15ccaac)), closes [#1171](#1171)
* infer column type using runner ([#1182](#1182)) ([846f404](846f404)), closes [#994](#994)
* integrate version 0.26.0 of the `safe-ds` Python library ([#1184](#1184)) ([e79de17](e79de17))
* show symbol types in headings and table of contents ([#1178](#1178)) ([b2f0966](b2f0966)), closes [#1164](#1164)
* sort rows in EDA ([#1183](#1183)) ([ddd5186](ddd5186)), closes [#1151](#1151)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SmiteDeluxe SmiteDeluxe

Labels
released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
DSL
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: infer column type from runner Safe-DS/DSL
2 participants
@lars-reimann @SmiteDeluxe