Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort rows in EDA tool #1151

Closed
lars-reimann opened this issue May 4, 2024 · 1 comment · Fixed by #1183
Closed

Sort rows in EDA tool #1151

lars-reimann opened this issue May 4, 2024 · 1 comment · Fixed by #1183
Assignees
@SmiteDeluxe
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

The buttons to sort rows in the EDA tool don't work.

Desired solution

They should sort the rows.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

Just adding this issue explicitly, since it came up during the evalutation.
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label May 4, 2024
@lars-reimann lars-reimann added this to DSL May 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL May 4, 2024
@SmiteDeluxe SmiteDeluxe mentioned this issue May 29, 2024
Merged
@SmiteDeluxe SmiteDeluxe linked a pull request May 29, 2024 that will close this issue
feat: sort rows in EDA #1183
Merged
lars-reimann added a commit that referenced this issue May 29, 2024
@SmiteDeluxe @megalinter-bot @lars-reimann
feat: sort rows in EDA (#1183)
ddd5186 
Closes #1151 

### Summary of Changes

- History has overrideId prop on entries now and RunnerAPI only keeps
last entry of each overrideId, allowing overriding sorts, voiding of
sorts and in general execution of only the relevant needed entries once
history is fully implemented
- Thus sorting working incl. visual feedback & loading screen if > 500ms
load & preserving of relevant state on Table update & removing of sort
by clicking active sort again
- All of pastEntries execution in correct order, with only relevant
entries & correct passing on of placeholders

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in DSL May 29, 2024
lars-reimann pushed a commit that referenced this issue May 29, 2024
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
4c93458 
## [0.17.0](v0.16.1...v0.17.0) (2024-05-29)

### Features

* hide columns in EDA ([#1181](#1181)) ([15ccaac](15ccaac)), closes [#1171](#1171)
* infer column type using runner ([#1182](#1182)) ([846f404](846f404)), closes [#994](#994)
* integrate version 0.26.0 of the `safe-ds` Python library ([#1184](#1184)) ([e79de17](e79de17))
* show symbol types in headings and table of contents ([#1178](#1178)) ([b2f0966](b2f0966)), closes [#1164](#1164)
* sort rows in EDA ([#1183](#1183)) ([ddd5186](ddd5186)), closes [#1151](#1151)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SmiteDeluxe SmiteDeluxe

Labels
enhancement 💡 New feature or request released Included in a release
Projects
DSL
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sort rows in EDA Safe-DS/DSL
2 participants
@lars-reimann @SmiteDeluxe