feat: infer column type from runner #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 110 110
Lines 19242 19242
Branches 4108 4108
=======================================
Hits 19202 19202
Misses 40 40 ☔ View full report in Codecov by Sentry. |
lars-reimann
approved these changes
May 28, 2024
lars-reimann
pushed a commit
that referenced
this pull request
May 29, 2024
## [0.17.0](v0.16.1...v0.17.0) (2024-05-29) ### Features * hide columns in EDA ([#1181](#1181)) ([15ccaac](15ccaac)), closes [#1171](#1171) * infer column type using runner ([#1182](#1182)) ([846f404](846f404)), closes [#994](#994) * integrate version 0.26.0 of the `safe-ds` Python library ([#1184](#1184)) ([e79de17](e79de17)) * show symbol types in headings and table of contents ([#1178](#1178)) ([b2f0966](b2f0966)), closes [#1164](#1164) * sort rows in EDA ([#1183](#1183)) ([ddd5186](ddd5186)), closes [#1151](#1151)
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994
Summary of Changes
EDA adds another execution in getting the Table placeholder to get column types with the .getColumn().isNumeric call that based on that evals to numeric or categorical type. In future also consider the temporal type, but will have to overhaul the profiling and filters for that.