Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: emojiPicker position #29408

Merged
merged 2 commits into from
Jun 5, 2023
Merged

regression: emojiPicker position #29408

merged 2 commits into from
Jun 5, 2023

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • fix position on smaller views
  • add scroll when height doesn't fit the view

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

⚠️ No Changeset found

Latest commit: 1543bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #29408 (1543bbd) into develop (d19fed6) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29408      +/-   ##
===========================================
+ Coverage    46.66%   46.69%   +0.03%     
===========================================
  Files          698      698              
  Lines        13071    13071              
  Branches      2226     2226              
===========================================
+ Hits          6099     6104       +5     
+ Misses        6652     6650       -2     
+ Partials       320      317       -3     
Flag Coverage Δ
e2e 46.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review May 31, 2023 14:30
@juliajforesti juliajforesti requested a review from a team as a code owner May 31, 2023 14:30
@ggazzo ggazzo changed the title fix: emojiPicker position regression: emojiPicker position Jun 5, 2023
@ggazzo ggazzo merged commit 1ca6d70 into develop Jun 5, 2023
@ggazzo ggazzo deleted the fix/emojiPicker branch June 5, 2023 19:59
gabriellsh added a commit that referenced this pull request Jun 6, 2023
…importer-messages-not-shown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  chore: Update codeowners to add ownership of rest typings package to backend (#29437)
  fix: Removed agent access to already taken rooms (#28979)
  fix: `queuedForUser` endpoint not filtering by status (#29189)
  regression: Marketplace Selectors (#29443)
  chore: fix contextualbar size (#29441)
  chore: `ComposerBoxPopup` Items alignment (#29320)
  feat: add support for `MONOLITH_TRANSPORTER` env var (#29373)
  fix: Import progress page stuck at 0% (#29421)
  feat: access-marketplace permission (#29203)
  chore(ddp-client): freeze data emitted by the sdk (#29430)
  refactor: `Table` on Integrations Page (#29428)
  regression: Update `LoadingIndicator` colors (#29424)
  chore(meteor): Update mention style (#29426)
gabriellsh added a commit that referenced this pull request Jun 12, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits)
  chore: Pages empty state consistency (#29439)
  refactor: Convert Omnichannel helper ee to ts (#29274)
  regression(i18n): Broken translations on client-side startup (#29442)
  chore: break down helpers.ts and create new files (#28611)
  test: runInBand unit test (#29484)
  i18n: system message copy updates (#29372)
  chore: emoji popup trigger length (#29282)
  fix: Seat counter including apps (#29489)
  fix: Invalid message draft (#29474)
  fix: message deletion fails if has files attached on filesystem storage (#29313)
  chore: replace meteor.call -> sdk.call (#29318)
  chore: deprecation api (#29347)
  fix: Imported messages are not displayed (#29416)
  chore: convert metrics to ts (#29475)
  chore: use new Livechat SDK Implementation (#29098)
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants