chore: deprecation api #29347
Merged
chore: deprecation api #29347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #29347 +/- ##
===========================================
+ Coverage 38.86% 46.66% +7.80%
===========================================
Files 662 699 +37
Lines 12591 13082 +491
Branches 2170 2228 +58
===========================================
+ Hits 4893 6105 +1212
+ Misses 7409 6658 -751
- Partials 289 319 +30
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
requested changes
May 25, 2023
apps/meteor/app/api/server/api.ts
Outdated
| @@ -180,7 +181,15 @@ export class APIClass<TBasePath extends string = ''> extends Restivus { | |||
| // eslint-disable-next-line @typescript-eslint/no-this-alias | |||
| const self = this; | |||
|
|
|||
| return parseJsonQuery(this.request.route, self.userId, self.queryParams, self.logger, self.queryFields, self.queryOperations); | |||
| return parseJsonQuery.call( | |||
There was a problem hiding this comment.
If you're passing this as context, wouldn't be better to let parseJsonQuery to get what it needs rather than passing a bunch of params? 👀
sampaiodiego
requested changes
Jun 6, 2023
apps/meteor/app/authorization/server/methods/removeUserFromRole.ts
Outdated
Show resolved
Hide resolved
sampaiodiego
approved these changes
Jun 6, 2023
gabriellsh
added a commit
that referenced
this pull request
Jun 12, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits) chore: Pages empty state consistency (#29439) refactor: Convert Omnichannel helper ee to ts (#29274) regression(i18n): Broken translations on client-side startup (#29442) chore: break down helpers.ts and create new files (#28611) test: runInBand unit test (#29484) i18n: system message copy updates (#29372) chore: emoji popup trigger length (#29282) fix: Seat counter including apps (#29489) fix: Invalid message draft (#29474) fix: message deletion fails if has files attached on filesystem storage (#29313) chore: replace meteor.call -> sdk.call (#29318) chore: deprecation api (#29347) fix: Imported messages are not displayed (#29416) chore: convert metrics to ts (#29475) chore: use new Livechat SDK Implementation (#29098) fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARCH-1105
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments