fix: check for $addToSet to be not empty before passing update params #29378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 580b7d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29378 +/- ##
===========================================
- Coverage 40.74% 30.96% -9.79%
===========================================
Files 679 576 -103
Lines 12857 10851 -2006
Branches 2188 1984 -204
===========================================
- Hits 5239 3360 -1879
+ Misses 7324 7281 -43
+ Partials 294 210 -84
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
previously approved these changes
May 26, 2023
dionisio-bot
bot
added
stat: ready to merge
debdutdeb
reviewed
May 31, 2023
KevLehman
changed the title
dionisio-bot
bot
added
stat: ready to merge
murtaza98
approved these changes
Jun 2, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2023
…importer-messages-not-shown * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) chore: Update codeowners to add ownership of rest typings package to backend (#29437) fix: Removed agent access to already taken rooms (#28979) fix: `queuedForUser` endpoint not filtering by status (#29189) regression: Marketplace Selectors (#29443) chore: fix contextualbar size (#29441) chore: `ComposerBoxPopup` Items alignment (#29320) feat: add support for `MONOLITH_TRANSPORTER` env var (#29373) fix: Import progress page stuck at 0% (#29421) feat: access-marketplace permission (#29203) chore(ddp-client): freeze data emitted by the sdk (#29430) refactor: `Table` on Integrations Page (#29428) regression: Update `LoadingIndicator` colors (#29424) chore(meteor): Update mention style (#29426)
gabriellsh
added a commit
that referenced
this pull request
Jun 12, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits) chore: Pages empty state consistency (#29439) refactor: Convert Omnichannel helper ee to ts (#29274) regression(i18n): Broken translations on client-side startup (#29442) chore: break down helpers.ts and create new files (#28611) test: runInBand unit test (#29484) i18n: system message copy updates (#29372) chore: emoji popup trigger length (#29282) fix: Seat counter including apps (#29489) fix: Invalid message draft (#29474) fix: message deletion fails if has files attached on filesystem storage (#29313) chore: replace meteor.call -> sdk.call (#29318) chore: deprecation api (#29347) fix: Imported messages are not displayed (#29416) chore: convert metrics to ts (#29475) chore: use new Livechat SDK Implementation (#29098) fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) ...
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC-967
OC-983
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments