Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an ASan issue in cost_test.cc #11371

Merged
merged 1 commit into from
May 6, 2019

Conversation

m-chaturvedi
Copy link
Contributor

@m-chaturvedi m-chaturvedi commented May 2, 2019

To reproduce: bazel test --config=asan --copt -O0 //solvers:cost_test

Error
Reference
Build failure


This change is Reviewable

@m-chaturvedi m-chaturvedi added unused team: kitware unused type: address-leak-sanitizer https://clang.llvm.org/docs/AddressSanitizer.html https://clang.llvm.org/docs/LeakSanitizer.html labels May 2, 2019
@m-chaturvedi
Copy link
Contributor Author

@drake-jenkins-bot mac-mojave-clang-bazel-experimental-address-sanitizer-release please

@jamiesnape
Copy link
Contributor

jamiesnape commented May 3, 2019

To clarify, the mac-mojave-clang-bazel-experimental-address-sanitizer failed build is expected, but the number of failed tests in that build has decreased by one?

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, given Jamie's clarification. (Can't think of how that wouldn't be the case...)

Reviewable status: needs at least two assigned reviewers (waiting on @EricCousineau-TRI)

@m-chaturvedi
Copy link
Contributor Author

To clarify, the mac-mojave-clang-bazel-experimental-address-sanitizer failed build is expected, but the number of failed tests in that build has decreased by one?

Sorry for the delay in replying.
Yes, the the number of failures decrease from 3 to 2.

//solvers:cost_test passes, //math:normalize_vector_test and //systems/rendering:pose_aggregator_test still fail.

@m-chaturvedi
Copy link
Contributor Author

+@SeanCurtis-TRI for platform review, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the basis that the changes seem, at the very least, harmless. I'll buy the "errors are getting better"-ness of this PR.

:LGTM:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)

@jamiesnape jamiesnape merged commit 83a0e32 into RobotLocomotion:master May 6, 2019
@m-chaturvedi m-chaturvedi mentioned this pull request May 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unused team: kitware unused type: address-leak-sanitizer https://clang.llvm.org/docs/AddressSanitizer.html https://clang.llvm.org/docs/LeakSanitizer.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants