-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an ASan issue in cost_test.cc #11371
Fix an ASan issue in cost_test.cc #11371
Conversation
@drake-jenkins-bot mac-mojave-clang-bazel-experimental-address-sanitizer-release please |
To clarify, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, given Jamie's clarification. (Can't think of how that wouldn't be the case...)
Reviewable status: needs at least two assigned reviewers (waiting on @EricCousineau-TRI)
Sorry for the delay in replying.
|
+@SeanCurtis-TRI for platform review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the basis that the changes seem, at the very least, harmless. I'll buy the "errors are getting better"-ness of this PR.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)
To reproduce:
bazel test --config=asan --copt -O0 //solvers:cost_test
Error
Reference
Build failure
This change is