Add iter size hints #141
Merged
Add iter size hints #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Kerollmops
approved these changes
Jan 13, 2022
| } | ||
| } | ||
|
|
||
| impl<'a> ExactSizeIterator for Iter<'a> { |
There was a problem hiding this comment.
Suggested change
| impl<'a> ExactSizeIterator for Iter<'a> { | |
| impl ExactSizeIterator for Iter<'_> { |
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
141: Add iter size hints r=Kerollmops a=saik0 This is a blocker for RoaringBitmap#140 as proptest calls `size_hint` when generate / shrinking. Could only implement ExactSizeIterator on the outer (Bit|Tree)Maps on 64 bit architectures to ensure the `u64` value is not truncated when casting to usize. Co-authored-by: saik0 <[email protected]>
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
142: Migrate to proptest r=Kerollmops a=saik0 Closes RoaringBitmap#140 Depends on RoaringBitmap#141 (will not work correctly with 0b4c044) See RoaringBitmap#140 for details Co-authored-by: saik0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a blocker for #140 as proptest calls
size_hintwhen generate / shrinking.Could only implement ExactSizeIterator on the outer (Bit|Tree)Maps on 64 bit architectures to ensure the
u64value is not truncated when casting to usize.