You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#141 Tracks cardinality remaining in the iterator.
The code it replaced would unconditionally panic. To guess the original author's intent: it was a runtime check that the count is tracked at the outer iterator. Panicking broke some new proptests, so we implemented the correct behavior. However, it is still true that the size hint is unreachable from the exposed API. The iterator is doing extra work the end user can never observe.
I suspect the regression went unnoticed since #125 plus this issue is still a net perf gain.
Proposing we just remove the size hints altogether and return the default (0, None). It will satisfy the validity requirements of tests without needlessly slowing down iteration.
The text was updated successfully, but these errors were encountered:
#141 Tracks cardinality remaining in the iterator.
The code it replaced would unconditionally panic. To guess the original author's intent: it was a runtime check that the count is tracked at the outer iterator. Panicking broke some new proptests, so we implemented the correct behavior. However, it is still true that the size hint is unreachable from the exposed API. The iterator is doing extra work the end user can never observe.
I suspect the regression went unnoticed since #125 plus this issue is still a net perf gain.
Proposing we just remove the size hints altogether and return the default
(0, None)
. It will satisfy the validity requirements of tests without needlessly slowing down iteration.The text was updated successfully, but these errors were encountered: