Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to proptest #142

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Migrate to proptest #142

merged 1 commit into from
Jan 13, 2022

Conversation

saik0
Copy link
Contributor

@saik0 saik0 commented Jan 13, 2022

Closes #140
Depends on #141 (will not work correctly with 0b4c044)

See #140 for details

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, it isn't even more complex than using quickcheck! I'll let you rebase on master, as I merged #141.

@saik0
Copy link
Contributor Author

saik0 commented Jan 13, 2022

This PR looks good, it isn't even more complex than using quickcheck! I'll let you rebase on master, as I merged #141.

Great! Rebased.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2022

Build succeeded:

@bors bors bot merged commit 7953723 into RoaringBitmap:master Jan 13, 2022
not-jan pushed a commit to not-jan/roaring-rs that referenced this pull request Aug 31, 2022
142: Migrate to proptest r=Kerollmops a=saik0

Closes RoaringBitmap#140 
Depends on RoaringBitmap#141 (will not work correctly with 0b4c044)

See RoaringBitmap#140 for details

Co-authored-by: saik0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Migrate from quickcheck to proptest
2 participants