Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.10.0 #408

Merged
merged 14 commits into from
Dec 28, 2017
Merged

Release 1.10.0 #408

merged 14 commits into from
Dec 28, 2017

Conversation

tkwidmer
Copy link
Contributor

Includes The following PRs
#383 @hectorsector AriaLabel for Screen Readers on Search and Search by Location
#389 @KurtPrice Patreon Button
#407 @DeeDeeG AriaLabel Unit Tests
#404 @DeeDeeG Vagrant Documentation
#403 @tkwidmer Fix footer being cut off
#391 @iforgotband Bump Bugsnag Version
#389 @stardust66 Fix for Vertical Align
#386 @DeeDeeG Navbar Brand Fix

Thanks everybody!

DeeDeeG and others added 13 commits November 3, 2017 18:57
@DeeDeeG
css: Update .navbar-brand width (45px -> 16em)
d44d3f4 
Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.
@stardust66
Use suggested workaround to fix VO for older iOS
b01f3e5
@mi-wood
Merge pull request #386 from DeeDeeG/fix-navbar-brand-text-overflow
2ca3c4a 
Fix text overflow by widening div.navbar-brand (45px -> 16em)
@mi-wood
Merge pull request #389 from stardust66/fix-button-vo
bdafa9a 
Use suggested workaround to fix VO for older iOS
@tkwidmer
Update README.md
c033a5e
@tkwidmer
Update CONTRIBUTING.md
1da2e6f
@stardust66 @tkwidmer
Set piwik to use async tracking in production (#395)
a2b34f1 
This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.
@iforgotband @tkwidmer
Bump bugnag version (#391)
b88b34d 
Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.
@tkwidmer
Fix Footer being cut off #401 (#403)
08f0a3e
@DeeDeeG @tkwidmer
contributing.md: Add a step to install VirtualBox (#404)
be29a57 
VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)
@DeeDeeG @tkwidmer
Adds unit tests to check that there are ARIA labels on the search but…
7ec48d2 
…tons (#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)
@KurtPrice @tkwidmer
Hotfix/patreon update (#398)
74e2fc5 
* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset
@hectorsector @tkwidmer
Label search buttons for screen readers (#383)
fc378fb 
* add aria-label to search button

* add aria-label to search-by-location button
@tkwidmer tkwidmer requested a review from mi-wood December 28, 2017 01:43
@tkwidmer tkwidmer changed the title Release Release 1.10.0 Dec 28, 2017
@tkwidmer tkwidmer added this to the 1.10.0 milestone Dec 28, 2017
@tkwidmer tkwidmer temporarily deployed to refuge-staging-14-pr-408 December 28, 2017 01:47 Inactive
@tkwidmer tkwidmer temporarily deployed to refuge-staging-14 December 28, 2017 01:53 Inactive
@tkwidmer
Copy link
Contributor Author

https://refuge-staging-14-pr-408.herokuapp.com/restrooms/new

https://refuge-staging-14-pr-408.herokuapp.com/restrooms

both seem to be broken

@tkwidmer
Copy link
Contributor Author

Raw staging seem to be working

https://refuge-staging-14.herokuapp.com/restrooms

@tkwidmer
Copy link
Contributor Author 

Completed 500 Internal Server Error in 6ms (ActiveRecord: 1.6ms)

2017-12-28T02:10:54.703071+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d] Not notifying due to an invalid api_key

2017-12-28T02:10:54.703858+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]   

2017-12-28T02:10:54.703896+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d] ActionView::Template::Error (PG::UndefinedTable: ERROR:  relation "restrooms" does not exist

2017-12-28T02:10:54.703897+00:00 app[web.1]: LINE 8:                WHERE a.attrelid = '"restrooms"'::regclass

2017-12-28T02:10:54.703897+00:00 app[web.1]:                                           ^

2017-12-28T02:10:54.703898+00:00 app[web.1]: :               SELECT a.attname, format_type(a.atttypid, a.atttypmod),

2017-12-28T02:10:54.703898+00:00 app[web.1]:                      pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod,

2017-12-28T02:10:54.703899+00:00 app[web.1]:                      c.collname, col_description(a.attrelid, a.attnum) AS comment

2017-12-28T02:10:54.703902+00:00 app[web.1]:                 FROM pg_attribute a

2017-12-28T02:10:54.703902+00:00 app[web.1]:                 LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum

2017-12-28T02:10:54.703903+00:00 app[web.1]:                 LEFT JOIN pg_type t ON a.atttypid = t.oid

2017-12-28T02:10:54.703903+00:00 app[web.1]:                 LEFT JOIN pg_collation c ON a.attcollation = c.oid AND a.attcollation <> t.typcollation

2017-12-28T02:10:54.703904+00:00 app[web.1]:                WHERE a.attrelid = '"restrooms"'::regclass

2017-12-28T02:10:54.703904+00:00 app[web.1]:                  AND a.attnum > 0 AND NOT a.attisdropped

2017-12-28T02:10:54.703904+00:00 app[web.1]:                ORDER BY a.attnum

2017-12-28T02:10:54.703905+00:00 app[web.1]: ):

2017-12-28T02:10:54.704042+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     24:   .row

2017-12-28T02:10:54.704043+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     25:     .col-sm-12.headroom

2017-12-28T02:10:54.704043+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     26:       #list.restrooms-list

2017-12-28T02:10:54.704044+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     27:         = render @restrooms

2017-12-28T02:10:54.704044+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     28:         = paginate @restrooms

2017-12-28T02:10:54.704044+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     29: / .row

2017-12-28T02:10:54.704045+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]     30: /   .col-xs-12.headroom

2017-12-28T02:10:54.704053+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d]   

2017-12-28T02:10:54.704083+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d] app/views/restrooms/index.html.haml:27:in `_app_views_restrooms_index_html_haml__2111402162399667545_70025681927420'

2017-12-28T02:10:54.704084+00:00 app[web.1]: [a1da516b-124e-411c-afa2-24b142ae715d] app/controllers/restrooms_controller.rb:11:in `index'

@tkwidmer
Copy link
Contributor Author

Looks like it may just be an issue with the Heroku deploy, redeploying. The database wasn't able to connect.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Dec 28, 2017

I can say: It works in Vagrant off of the current develop branch.

@tkwidmer
Copy link
Contributor Author

Had to adjust the database on Heroku, something was wonky with the deploy. So we should be good.

Looks like it's functioning properly.

https://refuge-staging-14-pr-408.herokuapp.com/

@tkwidmer tkwidmer merged commit b4f7cb7 into master Dec 28, 2017
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this pull request Oct 15, 2018
@tkwidmer @DeeDeeG
Release 1.10.0 (RefugeRestrooms#408)
e91bb0b 
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)

* contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404)

VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)

* Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)

* Hotfix/patreon update (RefugeRestrooms#398)

* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset

* Label search buttons for screen readers (RefugeRestrooms#383)

* add aria-label to search button

* add aria-label to search-by-location button
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this pull request Nov 3, 2018
@tkwidmer @DeeDeeG
Release 1.10.0 (RefugeRestrooms#408)
89b3f27 
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)

* contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404)

VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)

* Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)

* Hotfix/patreon update (RefugeRestrooms#398)

* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset

* Label search buttons for screen readers (RefugeRestrooms#383)

* add aria-label to search button

* add aria-label to search-by-location button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mi-wood mi-wood Awaiting requested review from mi-wood

Assignees

@mi-wood mi-wood

Labels
Release
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tkwidmer @DeeDeeG @mi-wood @stardust66 @iforgotband @KurtPrice @hectorsector