contributing.md: Add a step to install VirtualBox #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.)
|
LGTM |
tkwidmer
approved these changes
Dec 21, 2017
Merged
tkwidmer
added a commit
that referenced
this pull request
Dec 28, 2017
* css: Update `.navbar-brand` width (45px -> 16em) Wider div.navbar-brand element prevents text overflowing to two lines. This is for the "Refuge Restrooms" text at the top left of the page. * Use suggested workaround to fix VO for older iOS * Update README.md * Update CONTRIBUTING.md * Set piwik to use async tracking in production (#395) This prevents the tracking script from blocking the loading of other scripts, such as the Google Maps script. * Bump bugnag version (#391) Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI. * Fix Footer being cut off #401 (#403) * contributing.md: Add a step to install VirtualBox (#404) VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.) * Adds unit tests to check that there are ARIA labels on the search buttons (#407) * add aria-label to search button * add aria-label to search-by-location button * Add tests for ARIA labels on search buttons (splash page) * Hotfix/patreon update (#398) * Added patreon link to the _footer.html.haml file for all pages * Actually added patreon.png to app/assets/images/patreon.png * Moved google-play image to the same area as the app store image. * Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images * Changed code to make images side by side * fixed syntax issue in haml * Update to correct haml syntax * remove second offset * Label search buttons for screen readers (#383) * add aria-label to search button * add aria-label to search-by-location button
DeeDeeG
added a commit
to DeeDeeG/refugerestrooms
that referenced
this pull request
Oct 15, 2018
VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.)
DeeDeeG
pushed a commit
to DeeDeeG/refugerestrooms
that referenced
this pull request
Oct 15, 2018
* css: Update `.navbar-brand` width (45px -> 16em) Wider div.navbar-brand element prevents text overflowing to two lines. This is for the "Refuge Restrooms" text at the top left of the page. * Use suggested workaround to fix VO for older iOS * Update README.md * Update CONTRIBUTING.md * Set piwik to use async tracking in production (RefugeRestrooms#395) This prevents the tracking script from blocking the loading of other scripts, such as the Google Maps script. * Bump bugnag version (RefugeRestrooms#391) Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI. * Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403) * contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404) VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.) * Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407) * add aria-label to search button * add aria-label to search-by-location button * Add tests for ARIA labels on search buttons (splash page) * Hotfix/patreon update (RefugeRestrooms#398) * Added patreon link to the _footer.html.haml file for all pages * Actually added patreon.png to app/assets/images/patreon.png * Moved google-play image to the same area as the app store image. * Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images * Changed code to make images side by side * fixed syntax issue in haml * Update to correct haml syntax * remove second offset * Label search buttons for screen readers (RefugeRestrooms#383) * add aria-label to search button * add aria-label to search-by-location button
DeeDeeG
added a commit
to DeeDeeG/refugerestrooms
that referenced
this pull request
Nov 3, 2018
VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.)
DeeDeeG
pushed a commit
to DeeDeeG/refugerestrooms
that referenced
this pull request
Nov 3, 2018
* css: Update `.navbar-brand` width (45px -> 16em) Wider div.navbar-brand element prevents text overflowing to two lines. This is for the "Refuge Restrooms" text at the top left of the page. * Use suggested workaround to fix VO for older iOS * Update README.md * Update CONTRIBUTING.md * Set piwik to use async tracking in production (RefugeRestrooms#395) This prevents the tracking script from blocking the loading of other scripts, such as the Google Maps script. * Bump bugnag version (RefugeRestrooms#391) Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI. * Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403) * contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404) VirtualBox is required in order to run our Vagrant setup. (First-timers would get an error message about needing a "provider," but letting people know ahead of time to get VirtualBox is nicer.) * Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407) * add aria-label to search button * add aria-label to search-by-location button * Add tests for ARIA labels on search buttons (splash page) * Hotfix/patreon update (RefugeRestrooms#398) * Added patreon link to the _footer.html.haml file for all pages * Actually added patreon.png to app/assets/images/patreon.png * Moved google-play image to the same area as the app store image. * Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images * Changed code to make images side by side * fixed syntax issue in haml * Update to correct haml syntax * remove second offset * Label search buttons for screen readers (RefugeRestrooms#383) * add aria-label to search button * add aria-label to search-by-location button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary of Changes
CONTRIBUTING.mdto have a step telling folks to install VirtualBox.Checklist
Screenshots
Before
After