Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer text is cut off #401

Closed
tkwidmer opened this issue Dec 20, 2017 · 1 comment · Fixed by #403
Closed

Footer text is cut off #401

tkwidmer opened this issue Dec 20, 2017 · 1 comment · Fixed by #403

Comments

@tkwidmer
Copy link
Contributor

footer is cut off

Footer text is cut off, cannot read full text in footer, specificly the copyright. Should be an easy fix.

@tkwidmer
Copy link
Contributor Author

tkwidmer added a commit that referenced this issue Dec 20, 2017
tkwidmer added a commit that referenced this issue Dec 20, 2017
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off #401 (#403)
tkwidmer added a commit that referenced this issue Dec 28, 2017
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off #401 (#403)

* contributing.md: Add a step to install VirtualBox (#404)

VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)

* Adds unit tests to check that there are ARIA labels on the search buttons (#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)

* Hotfix/patreon update (#398)

* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset

* Label search buttons for screen readers (#383)

* add aria-label to search button

* add aria-label to search-by-location button
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Oct 15, 2018
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Oct 15, 2018
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Oct 15, 2018
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)

* contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404)

VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)

* Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)

* Hotfix/patreon update (RefugeRestrooms#398)

* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset

* Label search buttons for screen readers (RefugeRestrooms#383)

* add aria-label to search button

* add aria-label to search-by-location button
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Nov 3, 2018
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Nov 3, 2018
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)
DeeDeeG pushed a commit to DeeDeeG/refugerestrooms that referenced this issue Nov 3, 2018
* css: Update `.navbar-brand` width (45px -> 16em)

Wider div.navbar-brand element prevents text overflowing to two lines.

This is for the "Refuge Restrooms" text at the top left of the page.

* Use suggested workaround to fix VO for older iOS

* Update README.md

* Update CONTRIBUTING.md

* Set piwik to use async tracking in production (RefugeRestrooms#395)

This prevents the tracking script from blocking the loading of other
scripts, such as the Google Maps script.

* Bump bugnag version (RefugeRestrooms#391)

Doesn't appear to have any breaking changes, but do please test against my tests. I didn't see anything, neither did my CI.

* Fix Footer being cut off RefugeRestrooms#401 (RefugeRestrooms#403)

* contributing.md: Add a step to install VirtualBox (RefugeRestrooms#404)

VirtualBox is required in order to run our Vagrant setup.

(First-timers would get an error message about needing a "provider,"
but letting people know ahead of time to get VirtualBox is nicer.)

* Adds unit tests to check that there are ARIA labels on the search buttons (RefugeRestrooms#407)

* add aria-label to search button

* add aria-label to search-by-location button

* Add tests for ARIA labels on search buttons (splash page)

* Hotfix/patreon update (RefugeRestrooms#398)

* Added patreon link to the _footer.html.haml file for all pages

* Actually added patreon.png to app/assets/images/patreon.png

* Moved google-play image to the same area as the app store image.

* Added the patreon image with link to the index page. The patreon.png was also added to app/assets/images

* Changed code to make images side by side

* fixed syntax issue in haml

* Update to correct haml syntax

* remove second offset

* Label search buttons for screen readers (RefugeRestrooms#383)

* add aria-label to search button

* add aria-label to search-by-location button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant