feat(YouTube - Theme): Apply custom seekbar color to splash screen animation

[LisoUseInAIKyrios]

When using a custom seekbar color the color is now applied to the splash screen animation.

Works with 19.25+

aqua.mp4

yellow.mp4

green.mp4

[MarcaDian]

Ok, but how it looks on Cairo splash screen?

Screenrecorder-2024-11-24-17-37-29-385.mp4

[LisoUseInAIKyrios]

If a custom seekbar color is used then the non Cairo launch animation is forced.

The Cairo splash animation uses Lottie animation json files, and to support that would require either permanently changing the color at patch time (not desirable at all), or adding code to modify the JSON file as it's loaded into the Lottie animator.

[MarcaDian]

Ok, need to test how it will look, the Cairo splash screen is a little smaller than the legacy one.
And is it even possible to turn off the splash screen, or is there no profit in this?

[LisoUseInAIKyrios]

The splash animation shows on a cold launch and does not show when resuming or if it was recently launched.

There's a feature flag that turns off the splash screen animation, but I only briefly tried using it and I'm not sure how useful it would be. In some ways it's slightly annoying with the animation disabled because there is no fade out of the splash screen and it looks a little unpolished.

[LisoUseInAIKyrios]

I tried setting a second seekbar color since some of the existing hooks supports using a color gradient, but the two color seekbar is not shown in the player and I did not find using two colors as useful as I thought it could be. It's a hassle picking a second color that complements the primary seekbar color, and even when a perfect secondary color is selected it does not add much value to the experience.

[LisoUseInAIKyrios]

Do you have a custom seekbar color that is not FF0033?

[MarcaDian]

Sorry for the trouble. Repatched app and performed a clean installation, everything work, but I notice that when the Custom seekbar color is set to default FF0033, the splash screen seekbar color has the legacy red FF0000.

Edit: also FF0044 doesn't work, FF0055 works

[LisoUseInAIKyrios]

It's because the splash screen uses 8-bit color and not 24-bit, so FF0033 has a blue chanel of 0.6 bit which rounds down to effectively show as FF0000

It can use nearest rounding and that would round up the 0.6 bit to effectively give FF0055

Or could change to using 9-bit color, which would effectively show FF0033 as shade FF0024.

I'll try changing to 9-bit color.

[cyberboh]

@LisoUseInAIKyrios I see the commit fix 19.46 , so does the current patches actually support 19.46 or you will bump it sooner?

[LisoUseInAIKyrios]

No that commit was just to fix this PR with 19.46.

19.46 seems to work ok without this PR, but I'm not sure if there's more a/b test in 19.46 and I did not bother looking if any new ones exist.